Group dependabot github-action update PRs, delete dead docker updates #8044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
force-pushed
the
githubactions
branch
from
7d4a619
to
e87c0d0
Compare
jmagman
changed the title
jmagman
commented
Nov 8, 2024
| - "keyonghan" | ||
| - "yusuf-goog" | ||
| - "ricardoamador" | ||
| - "stuartmorgan" |
There was a problem hiding this comment.
@stuartmorgan I can also remove reviewers totally if you don't want this.
11 tasks
This was referenced Nov 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2024
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 11, 2024
`.github/dependabot.yml` configures dependabot to update the `uses` dependencies needed to run github actions. For example, dependabot opened #56191 and updated all the `.github/workflows/` yaml files to point to the latest version of `actions/checkout` Add a dependabot `group` so all github action dependencies are updated in the same PR, instead of one-per-dependency. For example, if there were an update for `actions/checkout` and `actions/setup-python`, dependabot will send out one PR updating both instead of one PR per dependency. https://github.com/flutter/engine/blob/35041f11874434233b98c095c591d85dd7772c5e/.github/workflows/third_party_scan.yml#L23-L28 New PRs from dependenabot will look like: __________ <img width="400" alt="Screenshot 2024-11-08 at 11 08 52�AM" src="https://github.com/user-attachments/assets/eebedf69-3fae-409b-9c88-c3afc8036c52"> __________ See also flutter/packages#8044 and flutter/flutter#158408 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2024
1. Delete bundler and docker, these directories no longer exist and we have no Docker or Gemfiles any more. 2. Update outdated reviewer list which was blocking any reviewers from being added. #157473 (comment) 3. Change github action update from daily to weekly 4. Add a `group` so all github action dependencies are updated in the same PR, instead of one-per-dependency. The PR will look like: __________ <img width="400" alt="Screenshot 2024-11-08 at 11 08 52�AM" src="https://github.com/user-attachments/assets/eebedf69-3fae-409b-9c88-c3afc8036c52"> __________ See also flutter/packages#8044
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2024
flutter/packages@72356fd...26e123a 2024-11-13 dasyad00@gmail.com [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 39979207+ThangVuNguyenViet@users.noreply.github.com [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 pq@users.noreply.github.com [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 feinstein@users.noreply.github.com [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 stuartmorgan@google.com [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 ditman@gmail.com [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 stuartmorgan@google.com [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 tobias@leafnode.se [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 stuartmorgan@google.com [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 engine-flutter-autoroll@skia.org Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 magder@google.com Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 stuartmorgan@google.com [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 stuartmorgan@google.com [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 stuartmorgan@google.com [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 magder@google.com Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 43054281+camsim99@users.noreply.github.com [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 magder@google.com Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 37028599+EArminjon@users.noreply.github.com [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 stuartmorgan@google.com [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Package was removed in #6898. However the path was still being passed to dependabot, which made it mad: ``` ERROR <job_916983349> Error during file fetching; aborting: No files found in /packages/platform/example/android/app ``` https://github.com/flutter/packages/actions/runs/11845225387/job/33010210199 I don't understand why this only started failing on #8044 and not when the package was removed (since it moved that path from one place to another https://github.com/flutter/packages/pull/8036/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28L571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot now supports grouping dependencies into one PR instead of one per dependency.
Group github-action updates into one PR. Make github-actions update weekly instead of daily. Remove docker since it was removed in #4822
This means a PR like #7813 will instead be grouped into one.
Here's an example of what that will look like: kubernetes-sigs/cluster-api#11347
https://github.com/kubernetes-sigs/cluster-api/blob/e13abeaed2bd3d7b04abd9c9823e2f4185fa6599/.github/dependabot.yaml#L10-L12
I also updated the reviewers to stop the "One or more of the users or teams you specified is not a collaborator" error.
Part of flutter/flutter#148098
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.