-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Added serviceTimeout code for google iab #2248
Conversation
e9b00e9
to
b7951af
Compare
@NikitaZhelonkin Thanks for spotting this. Could you reflect the change in the generated code as well? The steps to do so is mentioned in the comments above your change as well as in README. |
@cyanglaz I had already added changes to generated code |
Thanks a lot. We would also need tests and version update for this to be landed. Please let me know if you need any help :) |
Am I need add test after adding only one enum value? |
@NikitaZhelonkin Technically, we require all new PRs (If adding features or fixing bugs) to have tests. And I think a test for the enum case is pretty straight forward to add? Maybe we can just test if the json value for |
Closing this as #3287 has been landed and issue resolved. |
Fix for issue flutter/flutter#43969