[in_app_purchase] Added serviceTimeout code for google iab (test) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding failure details for driver tests * formate fix * addressing reviewer comments * addressing the reviewer comments. part 2 * fix error in response_data * addressing reviewer comments * fixing formatting * addressin reviewer comments. Carrying the repeated driver test code to e2e package * chaning the failure's details type from map to list * format changes * add documentation to public members * formatting * changing namespace name
…conflict with the Flutter Framework. (flutter#2627)
* Adds canResolveActivity method
Android: Replaces the check for ActivityTestRule and adds a second test for GrantPermissionRule enabled tests
…flutter#2657) This reverts commit a811e63.
…_web. (flutter#2658) flutter/plugins is currently red because inline analysis checks are no longer honored. `video_player_web` used a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via `// ignore` comments. Now that `// ignore` comments don't work, the tree has gone red. A proper fix for `video_player_web` will take longer than acceptable to unblock the flutter/plugins tree. This is a temporary mitigation so work can resume.
…lutter#2661) This reverts commit 6087741.
Adds an Android-only property for toggling zoom controls
…tter#2654) Co-authored-by: Aaron Clarke <aaclarke@google.com>
…tter#2660) Make the Delegate non-final to allow overriding. IDelegate is not enough for v2 embedding for GoogleSignIn and 1p auth plugin because activity and activity binding have to be involved. If we keep Delegate as a field for those plugins, make Delegate non-final so that it's easier for tests to override.
…`. (flutter#2649) The core plugin assumes that a not-authenticated user is being returned as null from the platform code, but the web implementation is currently returning a null-object (as in the design pattern). This change ensures that not signed-in users are returned as null, not as an object with all its properties set to null! Co-Authored-By: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* Fix issue 51773 * Update docs * Add tests * Delete IDEWorkspaceChecks.plist * Delete Flutter.podspec * Fix failing tests * resolve merge conflicts * merge * apply formatting result * revert changes in FLTConnectivityPlugin.m * Add test coverage and apply string changes * Fixing format issue * Remove transaction after finishTransaction
…er#2647) Dart dependency resolution for ^0.Y.Z versions only picks up Z changes, so the latest changes to the plugin hadn't been released to the public. This change bumps the version of the dependency to the latest ^0.9.1. Co-authored-by: David Iglesias <ditman@gmail.com>
…mpatible with framework (flutter#2950)
- Doc typos - Unused Java variables
The value returned is never null. This is already done correclty in the example app. Co-authored-by: Dan Field <dnfield@google.com>
* [battery] Fixed typo in README.md (flutter#2944) * [integration_test] Remove debugging statement (flutter#2963) Co-authored-by: Yash Johri <yashjohri1200@gmail.com>
Add README instructions for enablePendingPurchases. If a developer attempts to access this plugin on Android without invoking enablePendingPurchases, an exception is thrown. Related StackOverflow post: https://stackoverflow.com/questions/60046903/flutter-in-app-purchase-enablependingpurchases-enablependingpurchases-must
…form side (flutter#2967) * [integration_test] Show stack trace of widget test errors on the platform side We keep things simple for now, because this might change once we have a proper test reporter.
This is the first step in the federation of the plugin.
Co-authored-by: Kifah Meeran <23234883+MaskyS@users.noreply.github.com> Co-authored-by: Aloïs Deniel <alois.deniel@gmail.com> Co-authored-by: Colin Stewart <colin@owlfish.com>
…tter#2904) * screenshot taking works * squash commits. addressing reviewer comments. making drivercommandmanager->callback manager * addressing reviewer comment. mostly name changes * major rename on all files webdriveraction->webdrivercommand * remove files. use implements * remove timeout. add onScreenshot callback * remove remaning timeouts. add an error message for screenshots. use an object instead of strings for status messages * created a new issue * remove example screenshot saving since it's failing on android. examples in integration_test package is common * changing the version and the change log
Allow running incremental_build.sh on Windows under Git Bash. Longer term this script should be re-written in Dart (#64025), but for now this allows running the script on Windows bots.
* add json config * mv to .ci
This cleans up a number of unnecessary differences in the LICENSE files:
- Removes C++ comments ("// ") from the beginnings of all the lines in license files that had them.
- Standardizes on having a blank line after the copyright line.
- Standardizes on having the final newline in the file.
- Standardizes on the indentation of the bulleted conditions.
- Standardizes on the locations of line breaks (re-wrapping the text)
This makes the license bodies--not including the copyright line--in almost all files the same, and matches the exact formatting already used in flutter/flutter and flutter/engine.
The only remaining non-copyright-line differences should now be:
- packages/image_picker/image_picker/LICENSE has an extra license
- packages/google_sign_in/extension_google_sign_in_as_googleapis_auth/LICENSE use "Google LLC" rather than "Google Inc." in the third condition.
* Implement FlutterPlugin interface on the no-op plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android: Fixed bug due to code -3 (SERVICE_TIMEOUT) in
BillingResponseAdding tests
Related Issues
Fix for issue flutter/flutter#43969
Previous pull request flutter#2248
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?