This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[video_player_web] Add a custom analysis_options file to video_player_web. #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_web so the tree becomes green again.
|
This will have to be merged on red |
ferhatb
suggested changes
Apr 16, 2020
cyanglaz
reviewed
Apr 16, 2020
harryterkelsen
approved these changes
Apr 16, 2020
cyanglaz
approved these changes
Apr 17, 2020
ferhatb
approved these changes
Apr 17, 2020
|
I'll merge as soon as the CI finishes. |
mklim
approved these changes
Apr 17, 2020
|
Merging on red, after verifying |
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…_web. (flutter#2658) flutter/plugins is currently red because inline analysis checks are no longer honored. `video_player_web` used a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via `// ignore` comments. Now that `// ignore` comments don't work, the tree has gone red. A proper fix for `video_player_web` will take longer than acceptable to unblock the flutter/plugins tree. This is a temporary mitigation so work can resume.
4 tasks
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…_web. (flutter#2658) flutter/plugins is currently red because inline analysis checks are no longer honored. `video_player_web` used a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via `// ignore` comments. Now that `// ignore` comments don't work, the tree has gone red. A proper fix for `video_player_web` will take longer than acceptable to unblock the flutter/plugins tree. This is a temporary mitigation so work can resume.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…_web. (flutter#2658) flutter/plugins is currently red because inline analysis checks are no longer honored. `video_player_web` used a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via `// ignore` comments. Now that `// ignore` comments don't work, the tree has gone red. A proper fix for `video_player_web` will take longer than acceptable to unblock the flutter/plugins tree. This is a temporary mitigation so work can resume.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flutter/plugins is currently red because inline analysis overrides (ignores) are no longer honored, as described here: flutter/flutter#52899.
video_player_webused a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via// ignorecomments.Now that
// ignorecomments don't work, the tree has gone red.The fix for
video_player_webwill take longer than acceptable to unblock the flutter/plugins tree, so we're putting this mitigation so work can continue normally.This patch will be removed, once the affected APIs can be accessed without triggering analyzer errors.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?