Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player_web] Add a custom analysis_options file to video_player_web. #2658

Merged
merged 3 commits into from
Apr 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player/video_player_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.2+2

* Add `analysis_options.yaml` to the package, so we can ignore `undefined_prefixed_name` errors. Works around https://github.com/flutter/flutter/issues/41563.

## 0.1.2+1

* Make the pedantic dev_dependency explicit.
Expand Down
10 changes: 10 additions & 0 deletions packages/video_player/video_player_web/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This is a temporary file to allow us to unblock the flutter/plugins repo CI.
# It disables some of lints that were disabled inline. Disabling lints inline
# is no longer possible, so this file is required.
# TODO(ditman) https://github.com/flutter/flutter/issues/55000 (clean this up)

include: ../../../analysis_options.yaml

analyzer:
errors:
undefined_prefixed_name: ignore
2 changes: 1 addition & 1 deletion packages/video_player/video_player_web/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: video_player_web
description: Web platform implementation of video_player
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web
version: 0.1.2+1
version: 0.1.2+2

flutter:
plugin:
Expand Down
1 change: 1 addition & 0 deletions script/incremental_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ source "$SCRIPT_DIR/common.sh"
CUSTOM_ANALYSIS_PLUGINS=(
"in_app_purchase"
"camera"
"video_player/video_player_web"
)
# Comma-separated string of the list above
readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")
Expand Down