Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Geodesic Polyline support in iOS #2964

Merged
merged 11 commits into from
Sep 1, 2020

Conversation

kattaliraees
Copy link
Contributor

Description

Polylines in iOS are not curved based on the earth's curvature even if we set geodesic true in flutter dart code. This is because this property passed to the plugin native code isn't used. I have set this property after GMSPolyline Objc instance created

Related Issues

flutter/flutter#49189

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ditman ditman requested review from ditman and cyanglaz August 26, 2020 18:07
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format tests are failing, do you mind taking a look at them and fixing the formatting of your obj-c code?

@ditman

This comment has been minimized.

@kattaliraees
Copy link
Contributor Author

@ditman Yes. corrected

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look at this change, and I think this cannot be merge it as is, sorry it took me a while to notice!

I think you need to remove the geodesic property from the polyline constructor(s) and set the geodesic property of the polyline in the InterpretPolylineOptions static method here, similarly to how visible is being handled.

This change will make it work when adding a Polyline but also would allow your code to toggle geodesic on/off on polylines that are already created.

Can you re-implement this following the same pattern as the "visible" attribute of the polyline? (there's a setVisible method, the InterpretPolylineOptions can handle changes to visible, etc...

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, this is so much simpler now, thank you very much!

Can you rename "GeoDesic" / "geoDesic" to "Geodesic" / "geodesic"?

Other than that, this is great now!

@ditman ditman self-requested a review September 1, 2020 17:32
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one test failing, but it's because this branch hasn't been fully updated with master since last night. I'll merge this right away.

Thanks for your contribution!

@ditman ditman merged commit ae806de into flutter:master Sep 1, 2020
@ditman
Copy link
Member

ditman commented Sep 1, 2020

This has been tagged and published to google_maps_flutter: ^0.5.31

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants