Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Geodesic Polyline support in iOS #2596

Closed
wants to merge 6 commits into from
Closed

[google_maps_flutter] Geodesic Polyline support in iOS #2596

wants to merge 6 commits into from

Conversation

kattaliraees
Copy link
Contributor

Description

Polylines in iOS are not curved based on the earth's curvature even if we set geodesic true in flutter dart code. This is because this property passed to the plugin native code isn't used. I have set this property after GMSPolyline Objc instance created

Related Issues

flutter/flutter#49189

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ditman
Copy link
Member

ditman commented Apr 21, 2020

This PR is compatible with the upcoming google_maps_flutter federation PR.

@ditman
Copy link
Member

ditman commented Aug 25, 2020

@kattaliraees I've bumped the version of the plugin to 0.5.31 to see if analyze likes it better. Please, ensure that you follow the instructions in this message to sign the CLA with all the users that contributed to this PR!

@kattaliraees
Copy link
Contributor Author

@ditman I have signed the CLA in Mar 2020. No idea why it's not reflecting.

Screen Shot 2020-08-25 at 10 00 33 AM

@ditman
Copy link
Member

ditman commented Aug 25, 2020

@kattaliraees There's a couple of commits that seem to come from a different github user than your current one:

Maybe you can squash them into a commit with your new username and force-push the branch, the system would accept it?

Alternatively, you may be able to start a new branch so you don't have to worry about those two commits?

@kattaliraees
Copy link
Contributor Author

@ditman created another pull request

#2964

closing this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants