Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Added 'allowsInlineMediaPlayback' property #3334

Merged
merged 4 commits into from
Dec 16, 2020
Merged

[webview_flutter] Added 'allowsInlineMediaPlayback' property #3334

merged 4 commits into from
Dec 16, 2020

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Dec 16, 2020

Description

The PR includes following changes:

  • adds allowsInlineMediaPlayback property to WebView to support inline media playback in iOS.
  • switched to using collection literals for Set.

Related Issues

#25630
#42099

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mehmetf mehmetf requested a review from amirh as a code owner December 16, 2020 01:17
@google-cla google-cla bot added the cla: yes label Dec 16, 2020
@mehmetf mehmetf mentioned this pull request Dec 16, 2020
Closed
13 tasks
@mehmetf
Copy link
Contributor Author

mehmetf commented Dec 16, 2020

@blasten This is ready to be reviewed.

@mehmetf mehmetf requested a review from blasten December 16, 2020 17:11
amirh
amirh approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo one small documentation nit)

Thanks for the extra test coverage!

packages/webview_flutter/lib/webview_flutter.dart Outdated Show resolved Hide resolved
@mehmetf mehmetf merged commit aa8fcb4 into flutter:master Dec 16, 2020
@mehmetf mehmetf deleted the webview_inline_media branch December 16, 2020 17:51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
1bbd85a 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
7715fe2 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
d200603 
…lutter/plugins#3334)
@amirh amirh mentioned this pull request Dec 17, 2020
Closed
NickalasB added a commit to NickalasB/plugins that referenced this pull request Dec 17, 2020
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
84fe69a 
* master:
  [camera] Ios support documentation  (flutter#3335)
  Remove custom null safety analysis_options files (flutter#3339)
  [webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter#3334)
  [camera_platform_interface] Add torch definition to the FlashModes enum  (flutter#3326)
  [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter#3271)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/pubspec.yaml
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
fcae723 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
3758fcb 
…lutter/plugins#3334)
@blasten blasten mentioned this pull request Dec 18, 2020
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
b97d3f8 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
b8cc1da 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
99430e4 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
b01ee1c 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
019c353 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
d4310a3 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
1744b29 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
7ab4e77 
…lutter/plugins#3334)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 29, 2020
@engine-flutter-autoroll
aa8fcb4 [webview_flutter] Added 'allowsInlineMediaPlayback' property (f…
dda59b4 
…lutter/plugins#3334)
@popeyelau popeyelau mentioned this pull request Jan 3, 2021
Open
@gokhanbelli
Copy link

Although I made all the changes, the ipad is working in full screen but the iphone does not work

iphone.mov
ipad.mov

@darshankawar darshankawar mentioned this pull request Jan 12, 2021
Closed
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
@mehmetf @amantoux
[webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter…
ecc9686 
…#3334)
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
@mehmetf @adsonpleal
[webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter…
1594958 
…#3334)
@swift-kim swift-kim mentioned this pull request Apr 5, 2021
Merged
@stuartmorgan stuartmorgan mentioned this pull request Jun 2, 2021
Closed
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amirh amirh amirh approved these changes

@blasten blasten Awaiting requested review from blasten

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehmetf @gokhanbelli @amirh