[webview_flutter] Add webview_flutter_tizen package #54

seungsoo47 · 2021-03-29T06:02:48Z

This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec ([webview_flutter] Update README and pubspec #53)
bdd6a15 [webview_flutter] Enable intergation test ([webview_flutter] Enable intergation test #52)
18da2a6 [webview_flutter] Update code by flutter version-up ([webview_flutter] Update code by flutter version-up #49)
1b6eeed [webview_flutter] Handle CompositionEvent ([webview_flutter] Handle CompositionEvent #47)
791511e [webview_flutter] Optimize tbm allocation ([webview_flutter] Optimize tbm allocation #42)
7059ce2 [webview_flutter] Add cookie and scroll APIs ([webview_flutter] Add cookie and scroll APIs #40)
c5a8930 Add some APIs ([webview_flutter] Add some APIs #37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError ([webview_flutter] Add NavigationDelegate and onWebResourceError #36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks ([webview_flutter] Add removeJavascriptChannels API and Callbacks #31)
749930e [webview_flutter] Update LWE ([webview_flutter] Update LWE #28)
9e26386 [webview_flutter] Implement addJavascriptChannels() ([webview_flutter] Implement addJavascriptChannels() #27)
6a34ae0 [webview_flutter] Update LWE ([webview_flutter] Update LWE #26)
a438093 [webview_flutter] Add evaluateJavascript() function ([webview_flutter] Add evaluateJavascript() function #25)
0d2c271 [webview_flutter] Update webview to be focused ([webview_flutter] Update webview to be focused #19)
b02b245 Enable IMF on Webview ([webview_flutter_dev] Enable IMF on Webview #17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file ([webview_flutter_dev] Change webview interface && embedding lwe.so file #15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE ([webview_flutter_dev] Enable gl compositor at LWE #14)
e988cf0 Change method name's first letter ([webview_flutter_dev] Change method name's first letter #13)
cb8ee9b Handle key events for tizen webview ([webview_flutter_dev] Handle key events for tizen webview #11)
44987de [webview_flutter] Add webview_flutter initial package ([webview_flutter] Add webview_flutter initial package #7)

Co-authored-by: MuHong Byun mh.byun@samsung.com
Co-authored-by: Seungsoo Lee seungsoo47.lee@samsung.com

swift-kim · 2021-03-29T06:37:57Z

What are those .so files? Which source code were they built from?

seungsoo47 · 2021-03-29T06:49:35Z

The file is a library for Tizen lightweight web engine. Because the file is not included in Tizen Studio yet, we decided to include them in the plugin.

seungsoo47 · 2021-03-29T06:51:01Z

I am sorry, I found unnecessary files. I will remove them.

swift-kim · 2021-03-29T07:10:23Z

Where is the source code for the library? How can you build it?
You provided .so files for the arm architecture only. Isn't this plugin supported on emulators? If not, why?

the file is not included in Tizen Studio yet

Is the library expected to be part of the Tizen SDK? If so, is there any detailed plan?
Why is the library necessary for this plugin to function? What makes it differ from the built-in web engine shipped with existing Tizen devices?

packages/webview_flutter/tizen/project_def.prop

seungsoo47 · 2021-03-29T08:23:29Z

Please refer to link below:
https://review.tizen.org/gerrit/gitweb?p=platform/upstream/lightweight-web-engine.git;a=tree;h=refs/heads/tizen;hb=refs/heads/tizen
The library only supports the ARM architecture. Initially, we had implemented General Buffer-based webview, but after that, we changed to FBO-based webview to improve performance.
This guarantees better performance, but there was a problem not running on the emulator. The current solution is not satisfactory for both device and emulator, but we will try to find the solution ASAP.
I am not sure. But if the library is not included, one way is to include x86 library in the plugin.
We needed to implement a webview that can share memory buffer to draw web pages on the display, also we didn't know how flutter and dart work with built-in webview on devices.
So first we tried to merge the lightweight web engine that we made on Tizen. Later, We will extend to new webview with Tizen builtin web engine based on chromium.

swift-kim · 2021-03-29T08:52:44Z

Including a ELF file in source tree is not a good practice. ~~Would it be possible to let the user download the file directly from download.tizen.org or the Releases tab of this repo? (This idea was abandoned.)~~

Also why does the so file has the .mobile suffix in its name? Is the file expected work with any profile (wearable/tv)?

seungsoo47 · 2021-03-30T03:24:14Z

I have updated the file's suffix from'.mobile' to'.flutter'.

rwalczyna · 2021-03-31T08:51:13Z

packages/webview_flutter/tizen/src/webview.h

+  virtual void DispatchCompositionUpdateEvent(const char* str,
+                                              int size) override;
+  virtual void DispatchCompositionEndEvent(const char* str, int size) override;
+


When I tried to run example on Tizen device (flutter-tizen run -v), two errors occurred:

"/home/r.walczyna/tizen-studio/tools/smart-build-interface/../llvm-10/bin/clang++" -c "src/webview_flutter_tizen_plugin.cc" -o "Debug/src/webview_flutter_tizen_plugin.o" -DTIZEN_DEPRECATION -DDEPRECATION_WARNING -DTIZEN_DEPRECATION [...] In file included from src/webview_flutter_tizen_plugin.cc:16: src/webview.h:34:16: error: 'DispatchCompositionUpdateEvent' marked 'override' but does not override any member functions virtual void DispatchCompositionUpdateEvent(const char* str, ^ src/webview.h:36:16: error: 'DispatchCompositionEndEvent' marked 'override' but does not override any member functions virtual void DispatchCompositionEndEvent(const char* str, int size) override; ^ 2 errors generated.

After removing not needed overrides it has built successful.

It seems that you need to update flutter-tizen. Actually, I have updated "flutter_platform_view.h" in flutter engine and the file should been applied on flutter-tizen cache side.

@seungsoo47 An engine release containing this patch has just been released yesterday. The embedder API versioning is a quite complicated problem because a plugin can have only a constraint on the Flutter SDK version (below) but not the Tizen embedder version. I'll tell you a bit more about this matter later.

environment: flutter: ">=2.0.1"

swift-kim

I believe libraries that a plugin depends on (liblightweight-web-engine.flutter.so in this case) should not be manually copied from the plugin directory into a project directory by the developer. Instead, they should automatically be copied by the flutter-tizen tool into a build output directory directly (this can be done in TizenPlugins of tizen_build_target.dart). I or @HakkyuKim will prepare a fix for this if you agree.

packages/webview_flutter/.metadata

packages/webview_flutter/example/.metadata

packages/webview_flutter/CHANGELOG.md

packages/webview_flutter/example/pubspec.yaml

packages/webview_flutter/example/tizen/shared/res/input.html

packages/webview_flutter/example/tizen/tizen-manifest.xml

packages/webview_flutter/pubspec.yaml

seungsoo47 · 2021-04-01T05:13:02Z

I believe libraries that a plugin depends on (liblightweight-web-engine.flutter.so in this case) should not be manually copied from the plugin directory into a project directory by the developer. Instead, they should automatically be copied by the flutter-tizen tool into a build output directory directly (this can be done in TizenPlugins of tizen_build_target.dart). I or @HakkyuKim will prepare a fix for this if you agree.

Thank you for your help. Please correct the copy issue. And I will update results for other issues.

* This PR is created from the PR below: 2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53) bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52) 18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49) 1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47) 791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42) 7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40) c5a8930 Add some APIs (flutter-tizen#37) 3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36) 42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31) 749930e [webview_flutter] Update LWE (flutter-tizen#28) 9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27) 6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26) a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25) 0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19) b02b245 Enable IMF on Webview (flutter-tizen#17) 571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15) 3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14) e988cf0 Change method name's first letter (flutter-tizen#13) cb8ee9b Handle key events for tizen webview (flutter-tizen#11) 44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7) Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com>

swift-kim

Please avoid using force-push multiple times as it makes difficult to track code changes. 😢

Theses are just markers for revisiting the original source code later:

TizenWebView was copied and modified from AndroidWebView in package:webview_flutter/src/webview_android.dart.
- TizenView was copied and modified from AndroidView in package:flutter/src/widgets/platform_view.dart.
  - _TizenWebViewState was copied and modified from _AndroidViewState in the same file.
    - _TizenPlatformTextureView was copied from _AndroidPlatformView in the same file.
      - RenderTizenView was copied and modified from RenderAndroidView in package:flutter/src/rendering/platform_view.dart
        
        The enums PlatformViewHitTestBehavior and _PlatformViewState are from the same file.
        
        _PlatformViewGestureMixin and _PlatformViewGestureRecognizer were copied from the same file.
        
        _factoryTypesSetEquals and _factoriesTypeSet are from the same file.
    - TizenViewController was copied and modified from AndroidViewController and TextureAndroidViewController in package:flutter/src/services/platform_views.dart.
      - The enum _TizenViewState is the equivalent of _AndroidViewState in the same file.
    - PlatformViewsServiceTizen was copied and modified from PlatformViewsService in package:flutter/src/services/platform_views.dart.

Please correct me if anything is wrong.

packages/webview_flutter/README.md

packages/webview_flutter/example/tizen/tizen-manifest.xml

packages/webview_flutter/lib/webview_flutter_tizen.dart

packages/webview_flutter/README.md

* Replace tabs to spaces in the manifest file * Fix broken READEME.md * Remove unnecessary code

* In accordance with the guideline, I have updated the initialization code.

packages/webview_flutter/tizen/src/webview_factory.cc

packages/webview_flutter/tizen/src/webview.cc

swift-kim · 2021-04-02T13:33:47Z

packages/webview_flutter/tizen/src/webview.cc

+        }
+      } else {
+        throw std::invalid_argument("Unknown WebView setting: " + k);
+      }


The following two properties were added in webview_flutter:

allowsInlineMediaPlayback ([webview_flutter] Added 'allowsInlineMediaPlayback' property flutter/plugins#3334)

hasProgressTracking ([webview_flutter] Support for loading progress tracking flutter/plugins#2151)

I don't know if inline media playback is applicable for Tizen, but at least I can see the RegisterOnProgressChangedHandler API in the LWE WebContainer so hasProgressTracking might be supported by webview_flutter_tizen.

This plugin is in alpha version. As far as I know, the APIs have been added to the latest version. When our plugin is updated to chromium-based webview, APIs may be also updated.

packages/webview_flutter/tizen/src/webview.cc

packages/webview_flutter/README.md

* Data files will be created in application's private area. * Key event including Shift key value will be handled properly.

HakkyuKim · 2021-04-06T10:35:17Z

I believe libraries that a plugin depends on (liblightweight-web-engine.flutter.so in this case) should not be manually copied from the plugin directory into a project directory by the developer. Instead, they should automatically be copied by the flutter-tizen tool into a build output directory directly (this can be done in TizenPlugins of tizen_build_target.dart). I or @HakkyuKim will prepare a fix for this if you agree.

Work in progress: flutter-tizen/support-binary-dependencies-in-plugin

HakkyuKim · 2021-04-07T06:22:50Z

I believe libraries that a plugin depends on (liblightweight-web-engine.flutter.so in this case) should not be manually copied from the plugin directory into a project directory by the developer. Instead, they should automatically be copied by the flutter-tizen tool into a build output directory directly (this can be done in TizenPlugins of tizen_build_target.dart). I or @HakkyuKim will prepare a fix for this if you agree.

Work in progress: flutter-tizen/support-binary-dependencies-in-plugin

The feature is merged to master, the tool will now put dependent binaries in tpks. You need to set the project_def.prop file as follows:

...
USER_LIB_DIRS = lib/${BUILD_ARCH}
USER_LIBS = lightweight-web-engine.flutter
...

and place liblightweight-web-engine.flutter.so in tizen/lib/armel.

Future plugin projects created by the tool will have the following comments written in the project_def.prop file:

# To provide libraries for your plugin, you must put them in specific
# directories that match their supporting cpu architecture type.
# Due to compatibility issue with Tizen CLI, directory names must be armel for arm 
# and i586 for x86.

* Because the latest flutter-tizen supports automatic copy function of plugin-dependent libraries, I updated a prof file and removed a library using in this plugin.

seungsoo47 · 2021-04-07T07:48:39Z

@HakkyuKim Thank you. I updated it in accordance with your guidance and I checked that the example worked fine.

seungsoo47 force-pushed the webview_tizen branch from ba5dc06 to 573553c Compare March 29, 2021 06:57

swift-kim reviewed Mar 29, 2021

View reviewed changes

packages/webview_flutter/tizen/project_def.prop Outdated Show resolved Hide resolved

seungsoo47 force-pushed the webview_tizen branch 2 times, most recently from b3d8c5a to eeb05e5 Compare March 30, 2021 03:07

seungsoo47 force-pushed the webview_tizen branch from eeb05e5 to fe18993 Compare March 31, 2021 03:56

rwalczyna reviewed Mar 31, 2021

View reviewed changes

swift-kim reviewed Apr 1, 2021

View reviewed changes

seungsoo47 force-pushed the webview_tizen branch 2 times, most recently from 4ed2ec6 to 4e01af6 Compare April 1, 2021 06:08

swift-kim reviewed Apr 1, 2021

View reviewed changes

[webview_flutter] Update manifest file and remove unnecessary code

1d3dda4

* Replace tabs to spaces in the manifest file * Fix broken READEME.md * Remove unnecessary code

seungsoo47 force-pushed the webview_tizen branch from 4510e7a to 1d3dda4 Compare April 1, 2021 08:21

seungsoo47 added 2 commits April 1, 2021 17:51

[webview_flutter] Update initailization code

d26fb9b

* In accordance with the guideline, I have updated the initialization code.

Fix integration test bug

c93a5cc

swift-kim reviewed Apr 5, 2021

View reviewed changes

seungsoo47 force-pushed the webview_tizen branch from 968c170 to d5f2f22 Compare April 5, 2021 08:44

swift-kim reviewed Apr 5, 2021

View reviewed changes

packages/webview_flutter/README.md Outdated Show resolved Hide resolved

Fix bugs for data files and key events

79d10e5

* Data files will be created in application's private area. * Key event including Shift key value will be handled properly.

seungsoo47 force-pushed the webview_tizen branch from d5f2f22 to 79d10e5 Compare April 6, 2021 01:39

Apply latest flutter-tizen

d5c8227

* Because the latest flutter-tizen supports automatic copy function of plugin-dependent libraries, I updated a prof file and removed a library using in this plugin.

swift-kim approved these changes Apr 7, 2021

View reviewed changes

bwikbs approved these changes Apr 8, 2021

View reviewed changes

bwikbs merged commit f373b7c into flutter-tizen:master Apr 8, 2021

swift-kim mentioned this pull request Jun 3, 2021

[path_provider] Update README with correct information #122

Merged

swift-kim mentioned this pull request Jul 26, 2021

[webview_flutter] Clean up debug code & Organize source #156

Merged

swift-kim mentioned this pull request May 12, 2022

Fix dart analyze issues #384

Merged

swift-kim mentioned this pull request May 27, 2022

[webview_flutter] Migrate to new analysis options #397

Merged

swift-kim mentioned this pull request Nov 14, 2022

Add platform view support to flutter_tizen flutter-tizen/flutter-tizen#462

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter] Add webview_flutter_tizen package #54

[webview_flutter] Add webview_flutter_tizen package #54

seungsoo47 commented Mar 29, 2021

swift-kim commented Mar 29, 2021

seungsoo47 commented Mar 29, 2021

seungsoo47 commented Mar 29, 2021

swift-kim commented Mar 29, 2021

seungsoo47 commented Mar 29, 2021

swift-kim commented Mar 29, 2021 •

edited

Loading

seungsoo47 commented Mar 30, 2021

rwalczyna Mar 31, 2021

seungsoo47 Apr 1, 2021

swift-kim Apr 1, 2021 •

edited

Loading

swift-kim left a comment

seungsoo47 commented Apr 1, 2021

swift-kim left a comment

swift-kim Apr 2, 2021

seungsoo47 Apr 5, 2021

HakkyuKim commented Apr 6, 2021 •

edited

Loading

HakkyuKim commented Apr 7, 2021

seungsoo47 commented Apr 7, 2021 •

edited

Loading

[webview_flutter] Add webview_flutter_tizen package #54

[webview_flutter] Add webview_flutter_tizen package #54

Conversation

seungsoo47 commented Mar 29, 2021

swift-kim commented Mar 29, 2021

seungsoo47 commented Mar 29, 2021

seungsoo47 commented Mar 29, 2021

swift-kim commented Mar 29, 2021

seungsoo47 commented Mar 29, 2021

swift-kim commented Mar 29, 2021 • edited Loading

seungsoo47 commented Mar 30, 2021

rwalczyna Mar 31, 2021

Choose a reason for hiding this comment

seungsoo47 Apr 1, 2021

Choose a reason for hiding this comment

swift-kim Apr 1, 2021 • edited Loading

Choose a reason for hiding this comment

swift-kim left a comment

Choose a reason for hiding this comment

seungsoo47 commented Apr 1, 2021

swift-kim left a comment

Choose a reason for hiding this comment

swift-kim Apr 2, 2021

Choose a reason for hiding this comment

seungsoo47 Apr 5, 2021

Choose a reason for hiding this comment

HakkyuKim commented Apr 6, 2021 • edited Loading

HakkyuKim commented Apr 7, 2021

seungsoo47 commented Apr 7, 2021 • edited Loading

swift-kim commented Mar 29, 2021 •

edited

Loading

swift-kim Apr 1, 2021 •

edited

Loading

HakkyuKim commented Apr 6, 2021 •

edited

Loading

seungsoo47 commented Apr 7, 2021 •

edited

Loading