Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash] Readjust heading font sizes #1521

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 23, 2018

@chalin chalin requested a review from Sfshaza October 23, 2018 15:10
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Oct 23, 2018
@chalin
Copy link
Contributor Author

chalin commented Oct 23, 2018

This is a minor font size adjustment for headings. It uses a uniform rate of font-size decrease (0.5rem), from h1 to h4.

IMHO, it is an improvement over what we had. Travis is green so I'll merge this now. We can always tweak font sizes again later, if necessary.

@chalin chalin merged commit ba76dfa into dash Oct 23, 2018
@chalin chalin deleted the chalin-heading-font-size-1023 branch October 23, 2018 15:42
atsansone added a commit that referenced this pull request Feb 21, 2024
The Flutter docs site scores a [C for
security](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev).
One factor is the Content Security Policy, an HTTP header that can
prevent [Cross Site Scripting
(XSS)](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev)
attacks.

This PR adds the CSP to the Flutter docs site HTTP headers. It would
resemble the fix applied to the Dart homepage in
[Dart PR #3540](dart-lang/site-www#3540) based
on [Dart issue #1521](dart-lang/site-www#1521)

This change is based on the pub.dev site. Fixes #6381

Co-authored-by: Brett Morgan <brettmorgan@google.com>
atsansone added a commit to atsansone/website that referenced this pull request Apr 5, 2024
The Flutter docs site scores a [C for
security](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev).
One factor is the Content Security Policy, an HTTP header that can
prevent [Cross Site Scripting
(XSS)](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev)
attacks.

This PR adds the CSP to the Flutter docs site HTTP headers. It would
resemble the fix applied to the Dart homepage in
[Dart PR flutter#3540](dart-lang/site-www#3540) based
on [Dart issue flutter#1521](dart-lang/site-www#1521)

This change is based on the pub.dev site. Fixes flutter#6381

Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants