Closes #2601 - flutter logo is png inside svg #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sfshaza2
reviewed
Jan 14, 2020
src/_includes/header.html
Outdated
| @@ -7,7 +7,7 @@ | |||
| </button> | |||
|
|
|||
| <a class="navbar-brand" href="/"> | |||
| {% asset 'flutter-lockup.svg' alt='Flutter by Google' height="37" width="129" class="align-middle" %} | |||
| {% asset 'default.png' alt='Flutter by Google' height="37" width="129" class="align-middle" %} | |||
There was a problem hiding this comment.
Thanks for removing the image, @legalcodes! But can you use a more descriptive name for the file?
atsansone
added a commit
that referenced
this pull request
Feb 21, 2024
The Flutter docs site scores a [C for security](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev). One factor is the Content Security Policy, an HTTP header that can prevent [Cross Site Scripting (XSS)](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev) attacks. This PR adds the CSP to the Flutter docs site HTTP headers. It would resemble the fix applied to the Dart homepage in [Dart PR #3540](dart-lang/site-www#3540) based on [Dart issue #1521](dart-lang/site-www#1521) This change is based on the pub.dev site. Fixes #6381 Co-authored-by: Brett Morgan <brettmorgan@google.com>
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
The Flutter docs site scores a [C for security](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev). One factor is the Content Security Policy, an HTTP header that can prevent [Cross Site Scripting (XSS)](https://securityheaders.com/?q=https%3A%2F%2Fdocs.flutter.dev) attacks. This PR adds the CSP to the Flutter docs site HTTP headers. It would resemble the fix applied to the Dart homepage in [Dart PR flutter#3540](dart-lang/site-www#3540) based on [Dart issue flutter#1521](dart-lang/site-www#1521) This change is based on the pub.dev site. Fixes flutter#6381 Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2601
Before (in Firefox):
After (in localhost):
Also staged: https://jt-flutter-website-3.firebaseapp.com/