Improve Linux Install 4: Update PATH install section #9087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2023 20:01
Revise and streamline 'Update Your Path' section. The changes ensure consistency with our table of contents, glossary, and overall document formatting. They also enhance clarity, especially for novice users, and ensure all necessary links/alerts are logically placed and maintained. The update also preserves all markdown syntax and special inclusions like '{% include docs/dart-tool.md %}'.
Added original links.
ghost
requested review from
atsansone
suggested changes
Jul 21, 2023
| ``` | ||
| {% include docs/dart-tool.md %} | ||
|
|
||
| ### Update the path directly |
There was a problem hiding this comment.
From here down, you can probably delete.
There was a problem hiding this comment.
Thanks, I'll get started on fixing up these changes and resubmit, :)
atsansone
added
the
a.get-started
atsansone
added
review.await-update
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Updated the doc based on review feedback: -Write in active voice per GSG. -Use semantic breaks. -Write as shorter sentences per GSG. -Fixed list item numbers -Fixed PATH to `PATH` for consistency except in headings
atsansone
changed the title
|
This needs to wait until #9238 merges. It covers related material that reworks the underlying files involved in this PR. |
atsansone
approved these changes
Aug 23, 2023
atsansone
removed
review.copy
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Sep 19, 2023
_Description of what this PR is changing or adding, and why:_ This PR updates "Update your path", of the Linux Installation Guide for Flutter. The update aims to make the instructions more explicit, ensuring they work across different shells and sessions. It also explains the necessity of updating the path and the impact on Flutter commands. _Issues fixed by this PR (if any):_ This PR addresses issues related to shell discrepancies and the persistence of Flutter commands across sessions. ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
This PR updates "Update your path", of the Linux Installation Guide for Flutter. The update aims to make the instructions more explicit, ensuring they work across different shells and sessions. It also explains the necessity of updating the path and the impact on Flutter commands.
Fixes #7612
Fixes #8466
This PR addresses issues related to shell discrepancies and the persistence of Flutter commands across sessions.
Presubmit checklist