Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Getting Started POC #9238

Merged
merged 23 commits into from
Dec 20, 2023
Merged

Windows Getting Started POC #9238

merged 23 commits into from
Dec 20, 2023

Conversation

atsansone
Copy link
Contributor

@atsansone atsansone commented Aug 11, 2023

Staged

https://tony-flutter-site.web.app/get-started/install/windows/

Fixes #9333
Fixes #5735
Fixes #8099
Fixes #4941
Fixes #7778
Fixes #6934
Fixes #6913

Presubmit checklist

SDK where your `adb` tool is based.
To use a different Android SDK installation path with Flutter,
set the `ANDROID_SDK_ROOT` environment variable
to that installation directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing beeline


{% include docs/install/flutter-sdk.md target='mobile' os='Windows' -%}

{% include docs/install/flutter-doctor.md target='mobile' os='Windows' -%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing new line

@atsansone atsansone changed the title Windows Getting Started POC [Do not merge or review] Windows Getting Started POC Oct 26, 2023
@atsansone atsansone added the review.copy Awaiting Copy Review label Oct 26, 2023
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Nov 14, 2023

Visit the preview URL for this PR (updated for commit 96f2f7e):

https://flutter-docs-prod--pr9238-win-gs-poc-bl3lfrsz.web.app

@atsansone atsansone force-pushed the win_gs_poc branch 2 times, most recently from 604cfc2 to e985092 Compare November 15, 2023 20:45
@atsansone atsansone removed the review.copy Awaiting Copy Review label Nov 16, 2023
@domesticmouse
Copy link
Contributor

Just nits mainly

@atsansone atsansone force-pushed the win_gs_poc branch 2 times, most recently from 28000fb to 9860c67 Compare November 27, 2023 20:29
@atsansone atsansone merged commit 83a10b5 into flutter:main Dec 20, 2023
9 checks passed
atsansone added a commit that referenced this pull request Feb 21, 2024
_Description of what this PR is changing or adding, and why:_
Re-add the Build Tools for Visual Studio 2022 option. This is a
significantly smaller download than a full Visual Studio installation.

This was originally added by
#7484 but was removed by
#9238.

_Issues fixed by this PR (if any):_

## Presubmit checklist

- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
atsansone added a commit to atsansone/website that referenced this pull request Apr 5, 2024
_Description of what this PR is changing or adding, and why:_
Re-add the Build Tools for Visual Studio 2022 option. This is a
significantly smaller download than a full Visual Studio installation.

This was originally added by
flutter#7484 but was removed by
flutter#9238.

_Issues fixed by this PR (if any):_

## Presubmit checklist

- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.get-started Relates to the Getting Started section of docs.flutter.dev act.await-dev-pr Needs dev PR to merge before merging docs st.RFM.% Ready to merge or land with minor changes. No further review needed.
Projects
None yet
4 participants