-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android_alarm_manager_plus): we can now send extra data to alarm manager and receive it in our callback #1014
feat(android_alarm_manager_plus): we can now send extra data to alarm manager and receive it in our callback #1014
Conversation
Hey! Due to changes in our contributor guidelines, all PRs should now:
We would ask you kindly to update the PR following these changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I understand what is the goal this new feature is trying to accomplish, but I am not sure if the implementation will open for a lot of more bugs (and alarm_manager_plus is already very unstable unfortunately).
Now on the main branch there are integration tests for alarm_manager_plus. I'd like to ask you to merge main
into your working branch and give it a go at adding new integration tests that cover this new functionality.
...d/src/main/java/dev/fluttercommunity/plus/androidalarmmanager/FlutterBackgroundExecutor.java
Outdated
Show resolved
Hide resolved
...r_plus/android/src/main/java/dev/fluttercommunity/plus/androidalarmmanager/AlarmService.java
Show resolved
Hide resolved
packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/test/android_alarm_manager_test.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart
Outdated
Show resolved
Hide resolved
packages/android_alarm_manager_plus/lib/android_alarm_manager_plus.dart
Outdated
Show resolved
Hide resolved
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…_test.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
…plus.dart Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little nit-picking, but in my opinion the code style should be consistent. Plus the method name that has a typo and could be improved and the test description.
Thanks for fixing, I think we can merge very soon 🙏🏽🥳
Description
Now we can send extra data to alarm manager as Map and also we can receive them in our function callback. For example we can do this :
and in our alarmManagerCallback we can receive the extra params :
Related Issues
Issue 990
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
pubspec.yaml
andCHANGELOG.md
.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?