Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectivity_plus): Add connectivity_plus_web export #1278

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

nohli
Copy link
Member

@nohli nohli commented Oct 20, 2022

Description

This PR adds a missing export.

Related Issues

#1227 (comment)

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

In my case, connectivity_plus works on web without needing this change. Maybe is there's something that has changed by adding the flutter sdk requirement for 2.11?

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I didn't need this fix for me to work, I guess some users may need this depending on the SDK version they are running.

@nohli
Copy link
Member Author

nohli commented Oct 20, 2022

In my case, connectivity_plus works on web without needing this change. Maybe is there's something that has changed by adding the flutter sdk requirement for 2.11?

This issue was before the sdk change 🤷🏽‍♂️

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that this fix will be the last one for this move to 2 package structure 😄

@nohli
Copy link
Member Author

nohli commented Oct 20, 2022

Well, the Android test is still failing 🙈

@miquelbeltran
Copy link
Member

Well, the Android test is still failing 🙈

no worry about this, it is because the API 21 integration test fails, but it works on more recent Android versions ;)

@nohli nohli merged commit 1795b72 into main Oct 20, 2022
@nohli nohli deleted the fix/connectivity_plus branch October 20, 2022 14:35
@nohli
Copy link
Member Author

nohli commented Oct 20, 2022

Can we fix the test?

Another pub.dev/GitHub release today? 🙂
(also this change)

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants