-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connectivity_plus)!: two-package federated architecture #1227
Conversation
can't figure out why the Windows build fails, will boot up my Windows PC and check there 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's just fix the import in tests as advised by the analyzer action.
Seem unrelated to this package, will address on another PR |
Description
Refactor work for
connectivity_plus
.I discovered some tests in the web implementation that were not used/maintained, so I deleted them.
Related Issues
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).