Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connectivity_plus)!: two-package federated architecture #1227

Merged
merged 14 commits into from
Oct 13, 2022

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Oct 13, 2022

Description

Refactor work for connectivity_plus.

I discovered some tests in the web implementation that were not used/maintained, so I deleted them.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member Author

can't figure out why the Windows build fails, will boot up my Windows PC and check there 😂

@miquelbeltran miquelbeltran marked this pull request as ready for review October 13, 2022 10:46
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just fix the import in tests as advised by the analyzer action.

@miquelbeltran
Copy link
Member Author

Looks good to me. Let's just fix the import in tests as advised by the analyzer action.

Seem unrelated to this package, will address on another PR

@miquelbeltran miquelbeltran merged commit b206f0a into main Oct 13, 2022
@miquelbeltran miquelbeltran deleted the 1226-connectivity-plus branch October 13, 2022 11:56
@miquelbeltran miquelbeltran added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants