-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(network_info_plus)!: two-package federated architecture #1235
Conversation
Only the windows build is broken. |
Sure! Will do in the upcoming days |
Alright windows build is fixed, but actually I wasn't able to retrieve a single value using the example, so I am not even sure this plugin works -at all- on windows :) |
Thanks a lot!! Why the Could you please try if it works on During testing all plugins in the simulators, I often found values to be null. Thought, it's maybe a simulator thing. Or for example sensors on web. |
Yeah, it crashes, so it is impossible to run the example. These methods are not available on Windows as they are not implemented. I will check with main as well for the other methods, but I suspect they don't work either. Maybe because I am on an ethernet connection? 😂 |
Same thing on |
Description
Refactor network_info_plus from the federated architecture to a platform interface and a package with all platform implementations.
Related Issues
#1226
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).