fix(share_plus): Set exported=false for BroadcastReceiver on Android

[vbuberen]

Description

Addressing an issue reported in #1608. After looking at the documentation and code saw that we indeed don't need to have receiver exposed as only catch the intent that we launch from the app that uses share_plus

Docs on topic:

• https://developer.android.com/guide/topics/manifest/receiver-element
• https://developer.android.com/training/permissions/restrict-interactions#broadcast-receivers

Tested the change - no issues with getting result of share in example app.

Related Issues

Closes #1608

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I titled the PR using Conventional Commits.
• I did not modify the CHANGELOG.md nor the pubspec.yaml files.
• All existing and new tests are passing.
• The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
• No, this is not a breaking change.

[charafau]

Do we know why it was exported ? Was it on purpose or just a miss / was created exported by default?

[vbuberen]

Is it that big deal? You can ping author, who initially added this receiver and ask. I guess, it it because the author isn't a mobile dev, but I don't see why we should care about it, considering that the issue is resolved.

[nohli]

Maybe it was added during the Android v2 migration.
Also, it's true by default.

Are we sure users won't run into issues like this?

[vbuberen]

Maybe it was added during the Android v2 migration.
Also, it's true by default.

It was added while adding share result functionality. As to default or not - I have attached the docs in the PR description about why it is Ok to set to false.

Are we sure users won't run into issues like this?

Yes, I am sure. The issue you linked is about not having exported property defined at all for one of components, not about true or false.

[charafau]

thanks @vbuberen for PR !