Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share_plus): Set exported=false for BroadcastReceiver on Android #1613

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(share_plus): Set exported=false for BroadcastReceiver on Android #1613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/share_plus/share_plus/android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</provider>
<!-- This manifest declared broadcast receiver allows us to use an explicit
Intent when creating a PendingItent to be informed of the user's choice -->
<receiver android:name=".SharePlusPendingIntent" android:exported="true">
<receiver android:name=".SharePlusPendingIntent" android:exported="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why it was exported ? Was it on purpose or just a miss / was created exported by default?

Copy link
Collaborator Author

@vbuberen vbuberen Mar 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it that big deal? You can ping author, who initially added this receiver and ask. I guess, it it because the author isn't a mobile dev, but I don't see why we should care about it, considering that the issue is resolved.

<intent-filter>
<action android:name="EXTRA_CHOSEN_COMPONENT" />
</intent-filter>
Expand Down