Replace loki-stack helm chart with loki + promtail #23
Conversation
| "value": [ | ||
| "$__all" | ||
| ] | ||
| "current": {}, |
There was a problem hiding this comment.
It may be better to keep the default namespace value for this, otherwise the default dashboard shows logs of every application that's deployed across namespaces with controller label. Setting it to flux-system namespace ensures that only flux controller logs are displayed by default. It also limits the list of controllers shown in the controller drop-down menu to flux controller only, making it more of a flux logs dashboard and not a generic logs dashboard.
There was a problem hiding this comment.
Agree, will revert this!
There was a problem hiding this comment.
This still doesn't seem to have flux-system as the default namespace value.
mjtrangoni
force-pushed
the
replace-loki-stack
branch
2 times, most recently
from
0a7c54c
to
0f3bcb4
Compare
| "label": "app", | ||
| "refId": "LokiVariableQueryEditor-VariableQuery", | ||
| "stream": "{namespace=~\"$namespace\"}", | ||
| "type": 1 |
There was a problem hiding this comment.
I'm not sure what this is about. Wouldn't just label_values(app) work for the controller query like before?
|
@mjtrangoni It looks like there are some extra unnecessary changes in this PR that can be removed, so it only contains the changes that you intended - are you still there? If we don't hear back from you soon, we will probably try to rebase the extra changes out |
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
@kingdonb sorry, you are right. I will remove all my changes around the dashboard, and let this be merged. |
mjtrangoni
force-pushed
the
replace-loki-stack
branch
from
0f3bcb4
to
f5937ad
Compare
|
I don't think we should configure storage, if the user attempts to install this example on a kind cluster then it will break because no persistent volume claims are allowed. I just tested it and on my cluster I had this issue, because there was no storage driver for CSI configured: Other than that issue I think this is a great config update thank you for contributing it @mjtrangoni I'm just going by precedent that the old version with loki-stack did not configure the filesystem storage, I think that means it's using impermanent / non-persistent or ephemeral (tmp) storage, and that means that data is lost when loki restarts. I think that is OK. This is just an example config, users are not meant to literally take this repo and implement it without any changes. But maybe some docs about how to configure the storage sensibly would be a helpful addition? I just don't want the guide to break for kind users, so I guess we shouldn't be configuring storage as that will break it. |
|
Both Prometheus and Grafana use an |
|
IDK if the new Loki chart actually supports Maybe there is some way that we can hack it, but I tried messing with the config for half an hour and wound up at this issue where it seems like this wouldn't be supported as no production environment is complete without storage. I'm not sure what to do, it really sucks that loki doesn't seemingly have a way to install on kind clusters where there is no persistent volume (or maybe the local-path-storage is included now, I don't actually use kind myself, this is a talos cluster) |
|
The local-path-storage provider is included in Kind. |
|
I will give it a try with the new loki v3.0 helm chart next week, and also rebase against the upstream changes. |
|
@mjtrangoni, did you get the chance to update it to v3.0? |
Hi @darkowlzz,
related to #19, this replaces the deprecated
loki-stackhelm chart with the more powerfulloki+promtailhelm charts.By this change Loki will be upgraded from
v2.6.1tov2.9.3, and to get it running in my test environment I had to do some changes to the the loki dashboard. Let me know if you agree with those changes.Also found out that the prometheus-mixin projects use
/as separator in the dashboards names, so I changed the titles to make it more uniform as well.This adds Dashboards Links as Dropdown menu via the tag
flux, similar to what the Loki dashboards have.Thank you!