Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to configure exponential back-off retry #246

Closed
pjbgf opened this issue Apr 12, 2022 · 0 comments · Fixed by #297
Closed

Add flags to configure exponential back-off retry #246

pjbgf opened this issue Apr 12, 2022 · 0 comments · Fixed by #297
Labels
good first issue Good for newcomers
Milestone
GA

Comments

@pjbgf
Copy link
Member

pjbgf commented Apr 12, 2022 •
edited
Loading

Two new flags (--min-retry-delay and --max-retry-delay) have been added on fluxcd/pkg/runtime to enable users configuring the exponential back-off retry settings.

Those tags should be brought into image-reflector-controller in a similar way they were implemented in the other controllers:
fluxcd/source-controller#664
fluxcd/image-automation-controller#348

xref: fluxcd/pkg@4046043
@pjbgf pjbgf added the good first issue Good for newcomers label Apr 12, 2022
@pjbgf pjbgf added this to the GA milestone Aug 8, 2022
@pjbgf pjbgf mentioned this issue Aug 8, 2022
Merged
@pjbgf pjbgf closed this as completed in #297 Aug 8, 2022
@pjbgf pjbgf moved this to Since Last Dev Meeting in Maintainers' Focus Aug 8, 2022
@pjbgf pjbgf moved this from Since Last Dev Meeting to Done in Maintainers' Focus Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Maintainers' Focus
Status: Done
Milestone
GA
Development

Successfully merging a pull request may close this issue.

Add flags to configure exponential back-off retry pjbgf/image-reflector-controller
1 participant
@pjbgf