Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to configure exponential back-off retry #297

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Aug 8, 2022

Add two new flags to enable users to configure exponential back-off for Flux objects. The default values are now set to 750ms for minimum retry time, and 15min for max.

Fixes: #246.

@pjbgf pjbgf marked this pull request as draft August 8, 2022 15:59
@pjbgf
Copy link
Member Author

pjbgf commented Aug 8, 2022

Keeping this as draft as it under goes some long running tests.

Add two new flags to enable users to configure exponential
back-off for Flux objects. The default values are now
set to 750ms for minimum retry time, and 15min for max.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf marked this pull request as ready for review August 8, 2022 16:34
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pjbgf pjbgf merged commit 4df16e0 into fluxcd:main Aug 8, 2022
@pjbgf pjbgf deleted the backoff branch August 8, 2022 16:36
@pjbgf pjbgf added this to the GA milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add flags to configure exponential back-off retry
2 participants