Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Migrate to go module #35

Merged
merged 11 commits into from
Jan 27, 2020
Merged

Conversation

honnix
Copy link
Member

@honnix honnix commented Nov 28, 2019

@kumare3 PTAL

@honnix honnix force-pushed the go-module-migration branch 2 times, most recently from a14cc15 to 27e9ccc Compare January 21, 2020 11:10
wild-endeavor added a commit to flyteorg/boilerplate that referenced this pull request Jan 23, 2020
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made:

* flyteorg/datacatalog#21
* flyteorg/flytepropeller#38
* flyteorg/flyteadmin#35
* flyteorg/flyteplugins#36
* flyteorg/flytestdlib#50
* flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
wild-endeavor
wild-endeavor previously approved these changes Jan 24, 2020
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but conflicts with dep files? sigh, sorry, one last time?

@honnix
Copy link
Member Author

honnix commented Jan 24, 2020

LGTM.

@wild-endeavor wild-endeavor changed the title migrate to go module Migrate to go module Jan 27, 2020
@wild-endeavor wild-endeavor merged commit 62bbe0f into flyteorg:master Jan 27, 2020
@honnix honnix deleted the go-module-migration branch January 28, 2020 06:17
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made:

* flyteorg/datacatalog#21
* flyteorg/flytepropeller#38
* flyteorg/flyteadmin#35
* flyteorg/flyteplugins#36
* flyteorg/flytestdlib#50
* flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
migrate to go module
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants