This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Migrate to go mod #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kumare3 PTAL |
|
I think here is a problem: https://github.com/lyft/flyteplugins/blob/master/tests/redis_lookaside_buffer_test.go#L11
|
honnix
force-pushed
the
go-module-migration
branch
from
b9bce6d
to
c772b49
Compare
honnix
commented
Jan 21, 2020
go.mod
Outdated
|
|
||
| replace ( | ||
| github.com/GoogleCloudPlatform/spark-on-k8s-operator => github.com/lyft/spark-on-k8s-operator v0.1.3 | ||
| // FIXME: remove replace after flyteplugins migrated to go module |
There was a problem hiding this comment.
TODO: remove this replacement.
wild-endeavor
added a commit
to flyteorg/boilerplate
that referenced
this pull request
Jan 23, 2020
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
|
We will need to merge flyteplugins PR first because of those non-compilable code in flyteplugins master. |
EngHabu
approved these changes
Jan 27, 2020
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
migrate to go mod
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.