Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Add CI target #27

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add CI target #27

merged 1 commit into from
Mar 14, 2018

Conversation

kofalt
Copy link
Member

@kofalt kofalt commented Mar 14, 2018

Because why not. This simple target ensures that:

  1. The module is roughly valid python
  2. The manifest schema is correct
  3. Our example manifest and invocation validate

ehlertjd
ehlertjd approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@ehlertjd ehlertjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like to see negative tests in a future PR.

@kofalt
Copy link
Member Author

kofalt commented Mar 14, 2018

Agreed. We should have a "compliance suite" type concept, add wheel packaging. And more!

@kofalt kofalt merged commit 6cbb9cc into master Mar 14, 2018
@kofalt kofalt deleted the ci branch March 14, 2018 19:08
@gsfr
Copy link

gsfr commented Mar 15, 2018

👍

@kofalt
Copy link
Member Author

kofalt commented Mar 15, 2018

Idea filed as #29, incidentally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehlertjd ehlertjd ehlertjd approved these changes

Assignees

@gsfr gsfr

@ehlertjd ehlertjd

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kofalt @gsfr @ehlertjd