This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Add optional input values and test suite #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. LGTM |
lmperry
approved these changes
Apr 26, 2018
ehlertjd
suggested changes
Apr 26, 2018
examples/test.py
Outdated
|
|
||
| def test_folders(): | ||
| base = path.dirname(path.abspath(__file__)) | ||
| print base |
spec/readme.md
Outdated
| @@ -150,6 +150,8 @@ Like the inputs, you can add JSON schema constraints as desired. Please specify | |||
|
|
|||
| The example has named one config option, called "speed", which must be an integer between zero and three, and another called "coordinates", which must be a set of three floats. | |||
|
|
|||
| In some cases, a configuration option may not have a safe default, and it only makes sense to sometimes omit it entirely. If that is the case, specify `"optional": "true"` on that config key. | |||
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25, #29. This feature was the breaking point for not having at least a basic validation suite, so that is added as well. Basic but functional. Comments welcome.
Is this a semantic or operational change? If so: