Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt::join() not working without formatter specialisation #2040

Closed
bluescarni opened this issue Dec 1, 2020 · 1 comment
Closed

fmt::join() not working without formatter specialisation #2040

bluescarni opened this issue Dec 1, 2020 · 1 comment

Comments

@bluescarni
Copy link

Hello,

I don't know if this is the intended behaviour, but apparently fmt::join() does not work for types which do not provide a formatter specialisation, even if these types are streamable and can be formatted after the inclusion of fmt/ostream.h.

Godbolt link exhibiting the issue: https://godbolt.org/z/7z3jbo
@tt4g tt4g mentioned this issue Dec 3, 2020
Closed
@vitaut
Copy link
Contributor

vitaut commented Dec 3, 2020

I think adding support for streamable types is reasonable. PRs are welcome.

kamibo added a commit to kamibo/fmt that referenced this issue Dec 4, 2020
@kamibo
Reenable support for fallback formatter to join (fmtlib#2040)
742abd6
kamibo added a commit to kamibo/fmt that referenced this issue Dec 7, 2020
@kamibo
Reenable support for fallback formatter to join (fmtlib#2040)
ca5414c
kamibo added a commit to kamibo/fmt that referenced this issue Dec 7, 2020
@kamibo
Reenable support for fallback formatter to join (fmtlib#2040)
94383a5
kamibo added a commit to kamibo/fmt that referenced this issue Dec 8, 2020
@kamibo
Reenable support for fallback formatter to join (fmtlib#2040)
34c404c
kamibo added a commit to kamibo/fmt that referenced this issue Dec 8, 2020
@kamibo
Reenable support for fallback formatter to join (fmtlib#2040)
6d9892f
vitaut pushed a commit that referenced this issue Dec 8, 2020
@kamibo
Reenable support for fallback formatter in join (#2040) (#2050)
c20874c
@vitaut vitaut closed this as completed Dec 8, 2020
tchaikov added a commit to tchaikov/ceph that referenced this issue Jul 25, 2022
@tchaikov
include/types_fmt: use fmt::join() to format containers
8de28af 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue Jul 25, 2022
@tchaikov
include/types_fmt: use fmt::join() to format containers
260c263 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue Jul 25, 2022
@tchaikov
include/types_fmt: use fmt::join() to format containers
b7b7ff4 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
dparmar18 pushed a commit to ceph/ceph-ci that referenced this issue Jul 27, 2022
@tchaikov @dparmar18
include/types_fmt: use fmt::join() to format containers
bda1760 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
dparmar18 pushed a commit to ceph/ceph-ci that referenced this issue Jul 28, 2022
@tchaikov @dparmar18
include/types_fmt: use fmt::join() to format containers
3f3e8ba 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
nizamial09 pushed a commit to ceph/ceph-ci that referenced this issue Aug 1, 2022
@tchaikov @nizamial09
include/types_fmt: use fmt::join() to format containers
eda2c1b 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
nizamial09 pushed a commit to ceph/ceph-ci that referenced this issue Aug 2, 2022
@tchaikov @nizamial09
include/types_fmt: use fmt::join() to format containers
d22b25a 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
bosc0 pushed a commit to bosc0/ceph that referenced this issue Aug 16, 2022
@tchaikov
include/types_fmt: use fmt::join() to format containers
8e3e373 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Pegonzal pushed a commit to ceph/ceph that referenced this issue Oct 13, 2022
@tchaikov @Pegonzal
include/types_fmt: use fmt::join() to format containers
b55f553 
* add formatter for classes with stream insertion operator.
  as in fmtlib v6.1.2, which is the one shipped with ubuntu focal,
  fmt::join() requires the printed element to have formatter.
  see fmtlib/fmt#2040 and
  fmtlib/fmt#1462
* use template parameter pack to represent container template argument,
  simpler this way. also, this enables us to print specialized
  classes which uses non-default template parameters.
* use fmt::join() to print container elements. see also
  https://fmt.dev/latest/api.html#_CPPv4I0EN3fmt4joinE9join_viewIN6detail10iterator_tI5RangeEEN6detail10sentinel_tI5RangeEEERR5Range11string_view

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @bluescarni