-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spdlog and fmt::join #1757
Comments
There are issues that may be related: fmtlib/fmt#2040 EDIT: Can use fmt 7.x? The version of fmt bundled by spdlog 1.8.1 is 7.0.3. |
OK, thank you. |
I'm having a similar issue which I don't think is related to the fmtlib bug. I'm using spdlog-1.8.1 and external fmtlib-7.1.3 with gcc-10.2.0 on Gentoo. When compiling the following minimal example,
gcc fails with
Even cherrypicking the fix for the fmtlib bug doesn't fix this, so that's why I don't think it's related. |
Issue seems to be that when calling |
Just realised my issue got fixed with #1726. |
Hi,
I have made the upgrade to spdlog 1.8.1 with {fmt} 7.1.2. Previously, I was using {fmt} 6.2.0 and spdlog 1.5.0.
Sometimes, I have lines like the following one:
log->debug("message {}", fmt::join(v, ", "));
where v is for example a vector of strings.
This line does not compile anymore. The workaround I found is to call fmt::format like this:
log->debug("message {}", fmt::format("{}", fmt::join(v, ", ")));
It does not look great...
Maybe this is not a real issue and you recommend to do otherwise.
What would you suggest?
Thank you.
The text was updated successfully, but these errors were encountered: