Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 4.10 >> Gradle 5.2 #1039

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Gradle 4.10 >> Gradle 5.2 #1039

merged 1 commit into from
Feb 11, 2019

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Feb 10, 2019

Summary

Updated Android NDK build with Gradle. Build Log

Note

Previous builds with 4.10.2 generated humongous log for review and debug. I applied later version(5.x) to reduce them. Please reference the build log. However, as far as I know, most of Android Studio users use Gradle 4.x (usually 4.4 and 4.10 for the latest users).
So the new configuration is a kind of early adapting to them. I'd like to hear your opinion about this.

There are multiple ways to install Gradle in ubuntu. What we have used was downloading a specific version with wget.
This PR adopted the official way.

History

TravisCI
- replaced from manual Gradle download to install with 'sdkman'
- changed build name

Gradle
- updated build tool version
@vitaut vitaut merged commit 4a9d676 into fmtlib:master Feb 11, 2019
@vitaut
Copy link
Contributor

vitaut commented Feb 11, 2019

I'd like to hear your opinion about this.

I don't really have an opinion on this. Happy to trust your judgement.

@luncliff
Copy link
Contributor Author

@vitaut Appreciate for your trust. I will monitor the build / related issue for a while :)

@luncliff luncliff deleted the build/gradle branch February 11, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants