Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Android build (with Gradle) #926

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Update of Android build (with Gradle) #926

merged 3 commits into from
Nov 6, 2018

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Nov 2, 2018

I'm glad to make another PR for this library. Appreciate for your maintenance works.
More changes can be required when Gradle 5.0 is released. Please mention me if the build fails.

Summary

Updated Gradle and Travis YAML for Android build. Build Log

Seems like the build log is crazy. :(

  • Applied latest Gradle (ver. 4.10.2) and plugin (ver 3.1.3)
  • Latest NDK and c++17 for cxx flag

For more detailed explanation, please reference this commit: 65134fe

History

Recovery of Gradle build. 1 of N
Modified several apt configurationss and order of the build
Recovered Gradle build with latest release (ver. 4.10.2)

TravisCI
- Changed several apt configurations & build steps for Android

AndroidManifest:
- package name: fmt -> org.fmtlib

Gradle:
- Plugin version 3.1.3. Requires Gradle 4.4+
- Removed `x86` (duplicated with `x86_64`)
- `-std=c++17`. Latest NDK(clang7) should support this
- Missing `repositories` configuration

For some reason, the `repositories` config affects to the error:
"Could not find com.android.tools.lint:lint-gradle:26.1.3."
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Mostly looks good but I have a few comments inline.

.travis.yml Show resolved Hide resolved
support/AndroidManifest.xml Outdated Show resolved Hide resolved
support/build.gradle Outdated Show resolved Hide resolved
- #926
- The version of android build results follows latest release(5.2.1)
- Comment for Gradle and its plugin for android
 - `net.fmtlib` package name in the manifest
@vitaut vitaut merged commit 6b26e3f into fmtlib:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants