Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for fmt::printf on Power9 architecture with the XL compiler #3256

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Bugfix for fmt::printf on Power9 architecture with the XL compiler #3256

merged 8 commits into from
Jan 13, 2023

Commits on Jan 13, 2023

  1. Bugfix for fmt::printf on Power9 architecture with the XL compiler

    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    0a52742 View commit details
    Browse the repository at this point in the history

  2. Adds arg_formatter contructor using default locale 

    This avoids the need to pass a temporary (default) locale_ref.
    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    ed37406 View commit details
    Browse the repository at this point in the history

  3. Don't pass locale_ref into arg_formatter constructor in printf_arg_fo… 

    …rmatter
    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6cfc4c5 View commit details
    Browse the repository at this point in the history

  4. Use a pointer instead of a reference for specs in arg_formatter 

    Per PR suggestion.
    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    10e187d View commit details
    Browse the repository at this point in the history

  5. Remove constructors for arg_formatter struct

    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    af9a54a View commit details
    Browse the repository at this point in the history

  6. Apply XL compiler bugfix within printf_arg_formatter constructor

    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    e4645d2 View commit details
    Browse the repository at this point in the history

  7. Adds a factory function for arg_formatter w/ default locale_ref 

    Use this within printf_arg_formatter constructor as workaround
for XL compiler bug that optimizes away base class initializer.

Also: Reverts conversion of internal `specs` variable back to a const ref

Per PR suggestion.
    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    4097a24 View commit details
    Browse the repository at this point in the history

  8. Moved make_arg_formatter to printf.h 

    Per PR suggestion.
    @kennyweiss
    kennyweiss committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    ad7f0c2 View commit details
    Browse the repository at this point in the history