Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for fmt::printf on Power9 architecture with the XL compiler #3256

Merged
merged 8 commits into from
Jan 13, 2023
+9 −1
Merged

Bugfix for fmt::printf on Power9 architecture with the XL compiler #3256

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a52742
Bugfix for fmt::printf on Power9 architecture with the XL compiler
kennyweiss Dec 31, 2022
ed37406
Adds arg_formatter contructor using default locale
kennyweiss Jan 3, 2023
6cfc4c5
Don't pass locale_ref into arg_formatter constructor in printf_arg_fo…
kennyweiss Jan 3, 2023
10e187d
Use a pointer instead of a reference for specs in arg_formatter
kennyweiss Jan 9, 2023
af9a54a
Remove constructors for arg_formatter struct
kennyweiss Jan 9, 2023
e4645d2
Apply XL compiler bugfix within printf_arg_formatter constructor
kennyweiss Jan 9, 2023
4097a24
Adds a factory function for `arg_formatter` w/ default `locale_ref`
kennyweiss Jan 11, 2023
ad7f0c2
Moved make_arg_formatter to printf.h
kennyweiss Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion include/fmt/printf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,14 @@ template <typename Char> class printf_width_handler {
}
};

// Workaround for a bug with the XL compiler when initializing
// printf_arg_formatter's base class.
template <typename Char>
auto make_arg_formatter(buffer_appender<Char> iter, format_specs<Char>& s)
-> arg_formatter<Char> {
return {iter, s, locale_ref()};
}

// The ``printf`` argument formatter.
template <typename OutputIt, typename Char>
class printf_arg_formatter : public arg_formatter<Char> {
Expand All @@ -235,7 +243,7 @@ class printf_arg_formatter : public arg_formatter<Char> {

public:
printf_arg_formatter(OutputIt iter, format_specs<Char>& s, context_type& ctx)
: base{iter, s, locale_ref()}, context_(ctx) {}
: base(make_arg_formatter(iter, s)), context_(ctx) {}

OutputIt operator()(monostate value) { return base::operator()(value); }

Expand Down