Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround intel bug #3652

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Workaround intel bug #3652

merged 5 commits into from
Sep 21, 2023

Commits on Sep 20, 2023

  1. Workaround intel bug 

    Potential workaround / restructure for the intel bug that is the cause of fmtlib#3645.

Make the variable in the external struct instead an embedded static constexpr variable in the only function that uses the variable.
    @gsjaardema
    gsjaardema committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bbaac96 View commit details
    Browse the repository at this point in the history

  2. Finish the proposed change -- remove struct accessor

    @gsjaardema
    gsjaardema committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1de436e View commit details
    Browse the repository at this point in the history

  3. Refactor proposed intel fix. 

    Moved variable out of function to avoid specialization on Float.  Made it a separate function that is called from format_float.
    @gsjaardema
    gsjaardema committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4c346e9 View commit details
    Browse the repository at this point in the history

  4. Fix incorrect function name.

    @gsjaardema
    gsjaardema committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7572bf1 View commit details
    Browse the repository at this point in the history

  5. Add missing inline...

    @gsjaardema
    gsjaardema committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8e60c51 View commit details
    Browse the repository at this point in the history