Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2 stuck #15

Closed
TwistedModding opened this issue Jun 21, 2021 · 7 comments
Closed

v0.2 stuck #15

TwistedModding opened this issue Jun 21, 2021 · 7 comments
Labels
bug Something isn't working easynpc Issues/requests relating the EasyNPC app

Comments

@TwistedModding
Copy link

The latest version is getting stuck on "Done loading headparts, Building NPC Index"

Log Name: Application
Source: Application Hang
Date: 6/20/2021 9:23:41 PM
Event ID: 1002
Task Category: (101)
Level: Error
Keywords: Classic
User: N/A
Computer: DESKTOP-RNBH10N
Description:
The program EasyNPC.exe version 0.2.0.0 stopped interacting with Windows and was closed. To see if more information about the problem is available, check the problem history in the Security and Maintenance control panel.
Process ID: 6004
Start Time: 01d7664459db922a
Termination Time: 2
Application Path: D:\Modlist\tools\EasyNPC\EasyNPC.exe
Report Id: cb077145-36b1-4f59-9a25-6ffe7827781a
Faulting package full name:
Faulting package-relative application ID:
Hang type: Unknown

Event Xml:



1002
0
2
101
0
0x80000000000000

2406


Application
DESKTOP-RNBH10N



EasyNPC.exe
0.2.0.0
6004
01d7664459db922a
2
D:\Modlist\tools\EasyNPC\EasyNPC.exe
cb077145-36b1-4f59-9a25-6ffe7827781a




Unknown
55006E006B006E006F0077006E0000000000

It becomes unresponsive and then I have to close it through task manager. (I waited 10+ minutes to see if it would open, and it wouldnt) reverting to v0.12 allows me to launch the program.

@focustense
Copy link
Owner

focustense commented Jun 21, 2021

Thanks for the report. Since it's not a crash, Windows event log doesn't tell me anything useful. I'd need to see the EasyNPC log file in this case. They're always in %LocalAppData%\EasyNPC. Most likely, the last entry in it will indicate which plugin it's having a problem with.

The log on screen might also give you a clue. Does it get to the end of your load order or does it stop on one particular mod? If it actually finishes scanning all your mods then the status should change to "Preparing game profile..." - though if the app is literally hanging in the foreground, as opposed to some background task not finishing, then I guess it might not update the UI at that moment.

@focustense
Copy link
Owner

focustense commented Jun 21, 2021

I don't think there's anything in the two additional commits that could result in an infinite loop - at least, nothing that wasn't already there - and that's normally what would be the root cause of an app hang. Really, the only commit that could matter is the one changing plugin detection logic, but nothing in there stands out to me as a possible cause of hanging.

One possibility might be that you lost your settings on upgrade (that part is guaranteed) and it's somehow ended up trying to scan your whole hard drive for mods, or something unusual like that. There's a command-line flag I added for my own use which could help if that's what's happening: /forceintro. If you put that in the command-line arguments, then it will force the welcome screen, and by extension allow you to change settings before it tries to go through your plugins. Not sure if that's the problem or if correcting it would help, but it's another thing to try.

@focustense focustense added bug Something isn't working easynpc Issues/requests relating the EasyNPC app labels Jun 21, 2021
@TwistedModding
Copy link
Author

image
Log_20210621_103029_0458865.txt

the /forceintro command let me get to the welcome screen again to put my settings in again, but the app still hangs at the same place indefinetly.

@TwistedModding
Copy link
Author

image
it seems to still be doing something as the cpu usage jumps around a tiny bit. but i left it at this screen for 15 minutes yesterday, and it kept hanging

@focustense
Copy link
Owner

I think I have narrowed it down. Some of the ITPO-detection rules were moved from a UI class into the Rule Set, but the UI model included the master as an explicit "override" while the data model that the Rule Set operates on does not. So there is specifically a problem with ITM records, which I didn't have in my load order when I was testing. I tried it on a much larger load order and was able to repro.

It should be a simple fix since the method is already supposed to handle "no override" cases, just missed this one edge case.

@TwistedModding
Copy link
Author

Alright, I'll keep an eye on the releases tab and report back here later.

@focustense
Copy link
Owner

I've deprecated v0.2.0 considering the potential severity, and posted v0.2.1.

focustense added a commit that referenced this issue Jun 25, 2021
When fixing #15, another regression was introduced due to some logic that was added, made redundant, and only half-removed. This resulted in actual known masters failing to be excluded from the "try not to use these as masters" rule.

Fixes #19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easynpc Issues/requests relating the EasyNPC app
Projects
None yet
Development

No branches or pull requests

2 participants