Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

":Noice Telescope" not working #1024

Closed
4 tasks done
gabs712 opened this issue Dec 26, 2024 · 3 comments · Fixed by #1032 or #1015
Closed
4 tasks done

":Noice Telescope" not working #1024

gabs712 opened this issue Dec 26, 2024 · 3 comments · Fixed by #1032 or #1015
Labels
bug Something isn't working

Comments

@gabs712
Copy link

gabs712 commented Dec 26, 2024 •
edited
Loading

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of noice.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.11.0

Operating system/version

Ubuntu 24.04.1

Describe the bug

When running :Noice Telescope, i get the following error message:

[telescope] [WARN  20:26:15] /home/gabs/.local/share/nvim/lazy/telescope.nvim/lua/
telescope/pickers.lua:498: Finder failed with msg:  ...lazy/telescope.nvim/lua/telescope/
pickers/highlights.lua:33: Invalid 'hl_group': Expected Lua string

After that, none of the notifications get displayed.

Steps To Reproduce

Run :Noice Telescope

Expected Behavior

Notifications being displayed properly
@gabs712 gabs712 added the bug Something isn't working label Dec 26, 2024
@TyrannosaurusLjx
Copy link

maybe :Noice telescope ?

@gabs712
Copy link
Author

gabs712 commented Jan 2, 2025

It seems to behave the same

@hat0uma hat0uma mentioned this issue Jan 9, 2025
Merged
@aaronlifton
Copy link
Contributor

This PR #1034 needs to merged and this PR #1032 needs to add the code to fzf.lua to fix this

@aaronlifton aaronlifton mentioned this issue Jan 29, 2025
Merged
folke pushed a commit that referenced this issue Feb 6, 2025
@hat0uma
fix(telescope): handle hl_group ID correctly in picker (#1032)
002b202 
## Description

Since commit
[742610e](742610e),
extmark's hl_group can now be specified directly as an ID. This change
ensures that if the hl_group is provided as a number (ID), it is
resolved to its name using `synIDattr` for correct handling.

Fixes: #1024
folke pushed a commit that referenced this issue Feb 6, 2025
@aaronlifton
feat(fzf): fix fzf integration (#1048)
f3291db 
## Description
`<leader>snt` wasn't working properly

- the same fzf compatibility update as
#1034
- the hl_group update from #1032
but for `fzf.lua`

Those PRs should probably merged instead of this, but the hl_group
update one also needs to update `lua/noice/integrations/fzf.lua`
Figured I'd submit this to bump visibility of the issue.

## Related Issue(s)

#1029
#1024
@github-actions github-actions bot mentioned this issue Feb 6, 2025
Merged
folke pushed a commit that referenced this issue Feb 6, 2025
@github-actions
chore(main): release 4.10.0 (#1015)
cf758e9 
🤖 I have created a release *beep* *boop*
---


##
[4.10.0](v4.9.0...v4.10.0)
(2025-02-06)


### Features

* **fzf:** fix fzf integration
([#1048](#1048))
([f3291db](f3291db))


### Bug Fixes

* **cmdline:** use number indexed `vim.g.ui_cmdline_pos`
([eaed6cc](eaed6cc))
* **confirm:** fixed `vim.fn.confirm` on nightly (0.11). Closes
[#1036](#1036)
([00b5984](00b5984))
* **fzf-lua:** update `update_title` and `update_scrollbar` to
`update_preview_title` and `update_preview_scrollbar`
([#1034](#1034))
([5530d78](5530d78)),
closes [#1029](#1029)
* **nui:** don't error when border win was closed. Fixes
[#832](#832)
([d2b092a](d2b092a))
* **telescope:** handle hl_group ID correctly in picker
([#1032](#1032))
([002b202](002b202)),
closes [#1024](#1024)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@aaronlifton @TyrannosaurusLjx @gabs712