Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: :Noice fzf error #1029

Closed
4 tasks done
zhiim opened this issue Jan 7, 2025 · 2 comments · Fixed by #1034 or #1015
Closed
4 tasks done

bug: :Noice fzf error #1029

zhiim opened this issue Jan 7, 2025 · 2 comments · Fixed by #1034 or #1015
Labels
bug Something isn't working

Comments

@zhiim
Copy link
Contributor

zhiim commented Jan 7, 2025

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of noice.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.10.3

Operating system/version

openSUSE Tumbleweed 20240924 x86_64

Describe the bug

When use :Noice fzf, I got this error:

Error executing vim.schedule lua callback: ...hare/nvim/lazy/noice.nvim/lua/noice/integrations/fzf.lua:75: attempt to call method 'update_title' (a nil value)
stack traceback:
	...hare/nvim/lazy/noice.nvim/lua/noice/integrations/fzf.lua:75: in function 'populate_preview_buf'
	...hare/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/builtin.lua:377: in function 'populate_preview_buf'
	...hare/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/builtin.lua:394: in function ''
	vim/_editor.lua: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>

However, :Noice telescope works fine.
The same error occured when using the latest LazyVim.

Steps To Reproduce

Run :Noice fzf

Expected Behavior

No errors.

@aaronlifton
Copy link
Contributor

This PR #1034 needs to merged and this PR #1032 needs to add the code to fzf.lua to fix this

@anuragkumar2921
Copy link

I'm also getting this error. Also sometimes noice does not load the color scheme and default to tokyonight. Is this because of this issue?

@folke folke closed this as completed in 5530d78 Feb 6, 2025
folke pushed a commit that referenced this issue Feb 6, 2025
## Description
`<leader>snt` wasn't working properly

- the same fzf compatibility update as
#1034
- the hl_group update from #1032
but for `fzf.lua`

Those PRs should probably merged instead of this, but the hl_group
update one also needs to update `lua/noice/integrations/fzf.lua`
Figured I'd submit this to bump visibility of the issue.

## Related Issue(s)

#1029
#1024
folke pushed a commit that referenced this issue Feb 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.10.0](v4.9.0...v4.10.0)
(2025-02-06)


### Features

* **fzf:** fix fzf integration
([#1048](#1048))
([f3291db](f3291db))


### Bug Fixes

* **cmdline:** use number indexed `vim.g.ui_cmdline_pos`
([eaed6cc](eaed6cc))
* **confirm:** fixed `vim.fn.confirm` on nightly (0.11). Closes
[#1036](#1036)
([00b5984](00b5984))
* **fzf-lua:** update `update_title` and `update_scrollbar` to
`update_preview_title` and `update_preview_scrollbar`
([#1034](#1034))
([5530d78](5530d78)),
closes [#1029](#1029)
* **nui:** don't error when border win was closed. Fixes
[#832](#832)
([d2b092a](d2b092a))
* **telescope:** handle hl_group ID correctly in picker
([#1032](#1032))
([002b202](002b202)),
closes [#1024](#1024)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants