Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: pattern in icon rules causes icon to be applied to key hint that it shouldn't #727

Closed
4 tasks done
sjclayton opened this issue Jul 16, 2024 · 1 comment · Fixed by #730
Closed
4 tasks done

bug: pattern in icon rules causes icon to be applied to key hint that it shouldn't #727

sjclayton opened this issue Jul 16, 2024 · 1 comment · Fixed by #730
Labels
bug Something isn't working

Comments

@sjclayton
Copy link
Contributor

Did you check docs and existing issues?

  • I have read all the which-key.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of which-key.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.10.0

Operating system/version

Arch Linux

Describe the bug

Git filetype icon is applied in situations where it should be... such as below:

2024-07-16_12-50

Steps To Reproduce

  1. Open a file
  2. Type vi or 'va` for example
  3. Refer to screenshot above

Expected Behavior

Icon is not applied to pattern matches that are in the middle of a word.

Health

No response

Log

No response

Repro

No response
@sjclayton sjclayton added the bug Something isn't working label Jul 16, 2024
@sjclayton
Copy link
Contributor Author

sjclayton commented Jul 16, 2024 •
edited
Loading

Not sure what the solution is to this... as it would probably involve some regex foo, which may not be feasible.

Maybe something along the lines of adding an excludes field to patterns... 🤔

@folke folke closed this as completed in bb4e82b Jul 16, 2024
@github-actions github-actions bot mentioned this issue Jul 16, 2024
Merged
folke pushed a commit that referenced this issue Jul 17, 2024
@github-actions
chore(main): release 3.7.0 (#730)
df77add 
🤖 I have created a release *beep* *boop*
---


##
[3.7.0](v3.6.0...v3.7.0)
(2024-07-17)


### Features

* added `expand` property to create dynamic mappings. An example for
`buf` and `win` is included
([02f6e6f](02f6e6f))
* proxy mappings
([c3cfc2b](c3cfc2b))
* **state:** allow defering on certain operators. Closes
[#733](#733)
([984d930](984d930))


### Bug Fixes

* **buf:** create triggers for xo anyway. Fixes
[#728](#728)
([96b2e93](96b2e93))
* **icons:** added frontier pattern for `git`. Fixes
[#727](#727)
([bb4e82b](bb4e82b))
* **state:** dont popup when switching between v and V mode. Fixes
[#729](#729)
([8ddb527](8ddb527))
* **view:** always show a group as a group
([96a9eb3](96a9eb3))
* **view:** empty icons
([e2cacc6](e2cacc6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 3.7.0 folke/which-key.nvim
1 participant
@sjclayton