Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: popup in visual mode #728

Closed
4 tasks done
mvaldes14 opened this issue Jul 16, 2024 · 1 comment · Fixed by #730
Closed
4 tasks done

bug: popup in visual mode #728

mvaldes14 opened this issue Jul 16, 2024 · 1 comment · Fixed by #730
Labels
bug Something isn't working

Comments

@mvaldes14
Copy link

Did you check docs and existing issues?

  • I have read all the which-key.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of which-key.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.10.0

Operating system/version

MacOS 14.5

Describe the bug

Updated to the newest version of the plugin commit (903e468). Redid all of my mappings to the new spec and some of them are not fully working but i'll figure that out.

What's weird is that visual mode pop up no longer works if i select more than 1 line in visual mode.

Steps To Reproduce

  1. Ctrl + V to select a line and go up down to select more than 1 line
  2. Press leader key
  3. Pop up do not appear

Expected Behavior

Would expect pop up to appear regardless of how many lines are selected.
If i select a single line and press leader i can see the small pop up

Health

No response

Log

Using the minimal debug setup.

1. Select some lines
2. Command Whichkey
3. Error 481: No range allowed

Cloning lazy.nvim

E481: No range allowed

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/which-key.nvim", opts = {} },
    -- add any other plugins here
  },
})
@mvaldes14 mvaldes14 added the bug Something isn't working label Jul 16, 2024
@folke folke closed this as completed in 96b2e93 Jul 16, 2024
@mvaldes14
Copy link
Author

you sir are a beast - much appreciated!

folke pushed a commit that referenced this issue Jul 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.7.0](v3.6.0...v3.7.0)
(2024-07-17)


### Features

* added `expand` property to create dynamic mappings. An example for
`buf` and `win` is included
([02f6e6f](02f6e6f))
* proxy mappings
([c3cfc2b](c3cfc2b))
* **state:** allow defering on certain operators. Closes
[#733](#733)
([984d930](984d930))


### Bug Fixes

* **buf:** create triggers for xo anyway. Fixes
[#728](#728)
([96b2e93](96b2e93))
* **icons:** added frontier pattern for `git`. Fixes
[#727](#727)
([bb4e82b](bb4e82b))
* **state:** dont popup when switching between v and V mode. Fixes
[#729](#729)
([8ddb527](8ddb527))
* **view:** always show a group as a group
([96a9eb3](96a9eb3))
* **view:** empty icons
([e2cacc6](e2cacc6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant