Fix state out of sync issue caused by race condition

[fonsp]

Fix #2904 🌟 yay!!!

The problem was........

Pluto.jl/src/webserver/Dynamic.jl

Line 434 in 45be7c1

send_notebook_changes!(🙋; skip_send=true)

skip_send meant that the patch was not being sent 😑

skip_send?

skip_send was added in #2273, but right now it looks like that was a mistake. The comment says that it is needed to fix #1892, but #1892 is about bonds, and this change is in the :run_multiple_cells function that is not triggered during a bond run.

#1892?

The original fix from #1892 was also no longer working. I fixed this in a separate PR: #2992 :) But that's probably not related.

queued = true?

So why is this code here? This is from https://github.com/fonsp/Pluto.jl/pull/710/files#diff-d0b76cc753bebaa7bbde63848adae9617f1e69dd9cd9986b98b7a3c5e39fc02bR360-R372

When a cell is triggered with Shift+Enter, its state is set to queued = true immediately on the frontend. And this code does the same in the backend.

Solution

Instead of calling send_notebook_changes! with skip_send=true to go through the client state update logic, we now just update the client state dictionary directly.

[github-actions]

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="fix-running-forever-maybe")
julia> using Pluto

[fonsp]

run_threaded does not make a difference, also with julia --threads=auto

[fonsp]

TODO:
change big comment to not talk about 1891