Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermediate bond values again #2992

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Aug 12, 2024

This will fix #1891 again which got reopened by #2399

This PR actually contains two fixes! So now it's superfixed!!!

  1. The heuristic from New heuristic to skip intermediate bond values #1892 was updated to ignore patches related to status_tree.
  2. I continued Performance: throttled status update loop impacts performance on large notebooks #2978 and made sure that the status tree sync loop is also throttled at the start of the reactive run. Too many intermediate bond values #1891 was happening because of the initial status updates.

This time the fix also includes an end-to-end test with puppeteer :)

@fonsp fonsp added frontend Concerning the HTML editor backend Concerning the julia server and runtime labels Aug 12, 2024
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="fix-intermediate-bonds-values-again")
julia> using Pluto

@fonsp fonsp merged commit 01135f7 into main Aug 12, 2024
10 of 16 checks passed
@fonsp fonsp deleted the fix-intermediate-bonds-values-again branch August 12, 2024 15:19
@fonsp
Copy link
Owner Author

fonsp commented Aug 12, 2024

oops some last changes in fb2f187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many intermediate bond values
1 participant