Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New check: Check METADATA.pb category #2972

Closed
m4rc1e opened this issue Jul 15, 2020 · 1 comment
Closed

New check: Check METADATA.pb category #2972

m4rc1e opened this issue Jul 15, 2020 · 1 comment
Assignees
@felipesanches
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P1 Quick
Milestone
0.7.29

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 15, 2020

Just pushed an update to Encode whose category was "SAN_SERIF" when it should've been "SANS_SERIF".

google/fonts#2515

Check should ensure that the METADATA.pb category is one of the following ["MONOSPACE", "SANS_SERIF", "SERIF", "DISPLAY", "HANDWRITING"]
@felipesanches felipesanches self-assigned this Jul 15, 2020
@felipesanches felipesanches added this to the 0.8.0 milestone Jul 15, 2020
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Jul 15, 2020
@felipesanches
Copy link
Collaborator

felipesanches commented Jul 15, 2020 •
edited
Loading

I'll start with this as a code-test to describe (and enforce) the expected behavior for the proposed new check:

Screenshot from 2020-07-15 17-56-16

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 15, 2020
@felipesanches
new check com.google.fonts/check/metadata/category
adb77f2 
on googlefonts profile:
"Ensure category field is valid in METADATA.pb file"
(issue fonttools#2972)
@felipesanches felipesanches mentioned this issue Jul 15, 2020
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 15, 2020
@felipesanches
new check com.google.fonts/check/metadata/category
b7a61cb 
on googlefonts profile:
"Ensure category field is valid in METADATA.pb file"
(issue fonttools#2972)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 15, 2020
@felipesanches
new check com.google.fonts/check/metadata/category
4d2ca09 
on googlefonts profile:
"Ensure category field is valid in METADATA.pb file"
(issue fonttools#2972)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 15, 2020
@felipesanches
new check com.google.fonts/check/metadata/category
1f2e3b1 
on googlefonts profile:
"Ensure category field is valid in METADATA.pb file"
(issue fonttools#2972)
felipesanches added a commit that referenced this issue Jul 15, 2020
@felipesanches
new check com.google.fonts/check/metadata/category
9c25108 
on googlefonts profile:
"Ensure category field is valid in METADATA.pb file"
(issue #2972)
@felipesanches felipesanches modified the milestones: 0.8.0, 0.7.29 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P1 Quick
Projects
None yet
Milestone
0.7.29
Development

No branches or pull requests
2 participants
@felipesanches @m4rc1e