Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encodesans: v3.002 added. #2515

Merged
merged 1 commit into from
Jul 15, 2020
Merged

encodesans: v3.002 added. #2515

merged 1 commit into from
Jul 15, 2020

Conversation

thundernixon
Copy link
Collaborator

@thundernixon thundernixon commented Jun 24, 2020 •
edited
Loading

This PR corrects a naming issue found in the static files of Encode Sans in #2497, where they had the suffix SC in their family naming due to a conflated name-fixing script, which has since been separated. This PR represents Encode Sans as of thundernixon/Encode-Sans@6407de8.

Now, naming is corrected to avoid these suffixing errors. For example, here are some names in static/EncodeSans-CondensedBlack.ttf:

<namerecord nameID="1" platformID="1" platEncID="0" langID="0x0" unicode="True">
    Encode Sans Cnd Black
</namerecord>
<namerecord nameID="3" platformID="1" platEncID="0" langID="0x0" unicode="True">
    3.002;GOOG;EncodeSans-CndBlack
</namerecord>
<namerecord nameID="4" platformID="1" platEncID="0" langID="0x0" unicode="True">
    Encode Sans Cnd Black
</namerecord>

I have also bumped the version number of the VF & static fonts to 3.002, to keep things in sync.

I have checked with fdiff that the VF has no changes besides version numbering:

▶ fdiff /Users/stephennixon/type-repos/google-font-repos/fonts/ofl/encodesans/EncodeSans\[wdth,wght\].ttf fonts/EncodeSans/EncodeSans\[wdth,wght\].ttf
--- /Users/stephennixon/type-repos/google-font-repos/fonts/ofl/encodesans/EncodeSans[wdth,wght].ttf     2020-06-24T15:27:10.311212-04:00
+++ fonts/EncodeSans/EncodeSans[wdth,wght].ttf  2020-06-24T13:56:03.723376-04:00
@@ -1222,13 +1222,13 @@
   <head>
     <!-- Most of this table will be recalculated by the compiler -->
     <tableVersion value="1.0"/>
-    <fontRevision value="3.001"/>
-    <checkSumAdjustment value="0x96fcd5fb"/>
+    <fontRevision value="3.002"/>
+    <checkSumAdjustment value="0x94db0e0d"/>
     <magicNumber value="0x5f0f3cf5"/>
     <flags value="00000000 00000011"/>
     <unitsPerEm value="2000"/>
     <created value="Thu Apr 30 16:07:15 2020"/>
-    <modified value="Thu Jun 11 22:32:26 2020"/>
+    <modified value="Wed Jun 24 17:56:00 2020"/>
     <xMin value="-300"/>
     <yMin value="-460"/>
     <xMax value="2122"/>
@@ -23786,13 +23786,13 @@
       Regular
     </namerecord>
     <namerecord nameID="3" platformID="3" platEncID="1" langID="0x409">
-      3.001;GOOG;EncodeSans-CondensedThin
+      3.002;GOOG;EncodeSans-CondensedThin
     </namerecord>
     <namerecord nameID="4" platformID="3" platEncID="1" langID="0x409">
       Encode Sans Condensed Thin
     </namerecord>
     <namerecord nameID="5" platformID="3" platEncID="1" langID="0x409">
-      Version 3.001
+      Version 3.002
     </namerecord>
     <namerecord nameID="6" platformID="3" platEncID="1" langID="0x409">
       EncodeSans-CondensedThin

I have updated the PR #2439 for the SC families with version 3.002, to keep everything together.

@thundernixon thundernixon requested a review from m4rc1e June 24, 2020 19:39
@gf-bot
Copy link

gf-bot commented Jun 24, 2020

Fontbakery report

Fontbakery version: 0.7.27

[1] Family checks
⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available? 
--- Rationale ---

There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.

If Font Bakery is not running on an OSX machine, the machine running Font
Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure
call (rpc).

There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator
  • ⚠ WARN Could not find ftxvalidator.

[3] EncodeSans[wdth,wght].ttf
🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'. 
--- Rationale ---

Some designers adopt the "Reserved Font Name" clause of the OFL license. This
means that the original author reserves the rights to the family name and other
people can only distribute modified versions using a different family name.

Google Fonts published updates to the fonts in the collection in order to fix
issues and/or implement further improvements to the fonts. It is important to
keep the family name so that users of the webfonts can benefit from the
updates. Since it would forbid such usage scenario, all families in the GFonts
collection are required to not adopt the RFN clause.

This check ensures "Reserved Font Name" is not mentioned in the name table.
  • 🔥 FAIL Name table entry ("Copyright 2020 The Encode Project Authors (https://github.com/thundernixon/Encode-Sans), with Reserved Font Name 'Encode Sans'.") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Combined length of family and style must not exceed 27 characters. 
--- Rationale ---

According to a GlyphsApp tutorial [1], in order to make sure all versions of
Windows recognize it as a valid font file, we must make sure that the
concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style
(NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20
characters.

After discussing the problem in more detail at `FontBakery issue #2179 [2] we
decided that allowing up to 27 chars would still be on the safe side, though.

[1]
https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances
[2] https://github.com/googlefonts/fontbakery/issues/2179
  • ⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Encode Sans Condensed Thin' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 3 35 10 126 0
0% 1% 2% 20% 6% 72% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: qa.zip

@m4rc1e m4rc1e merged commit ec8be82 into master Jul 15, 2020
@m4rc1e m4rc1e deleted the encodesans branch July 15, 2020 11:04
@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 15, 2020

Thanks! LGTM

@m4rc1e m4rc1e mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e Awaiting requested review from m4rc1e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thundernixon @gf-bot @m4rc1e