-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encodesans: v3.001 added. #2497
Conversation
Fontbakery reportFontbakery version: 0.7.27 [1] Family checks⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?--- Rationale --- There's no reasonable (and legal) way to run the command `ftxvalidator` of the Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc. If Font Bakery is not running on an OSX machine, the machine running Font Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call (rpc). There's an ssh example implementation at: https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds /ftxvalidator/ssh-implementation/ftxvalidator
[4] EncodeSans[wdth,wght].ttf🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'.--- Rationale --- Some designers adopt the "Reserved Font Name" clause of the OFL license. This means that the original author reserves the rights to the family name and other people can only distribute modified versions using a different family name. Google Fonts published updates to the fonts in the collection in order to fix issues and/or implement further improvements to the fonts. It is important to keep the family name so that users of the webfonts can benefit from the updates. Since it would forbid such usage scenario, all families in the GFonts collection are required to not adopt the RFN clause. This check ensures "Reserved Font Name" is not mentioned in the name table.
🔥 FAIL: A static fonts directory with at least two fonts must accompany variable fonts--- Rationale --- Variable font family directories kept in the google/fonts git repo must include a static/ subdir containing static fonts. These files are meant to be served for users that still lack support for variable fonts in their web browsers.
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Combined length of family and style must not exceed 27 characters.--- Rationale --- According to a GlyphsApp tutorial [1], in order to make sure all versions of Windows recognize it as a valid font file, we must make sure that the concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style (NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20 characters. After discussing the problem in more detail at `FontBakery issue #2179 [2] we decided that allowing up to 27 chars would still be on the safe side, though. [1] https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances [2] https://github.com/googlefonts/fontbakery/issues/2179
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] Summary
Note: The following loglevels were omitted in this report:
Diff images: qa.zip |
Thanks. LGTM. |
I don't want to delay publication, as this version is much better than the previous one, but why Encode Sans "SC" in nameID 1, 3 and 4 (static files)? |
Good spot @thlinard.
@thundernixon would you mind updating the static files? |
😬 Thanks for spotting that, @thlinard. I’ve done a bit of digging, and found that the problem is caused by unwisely combining logic to fix SC names with logic to abbreviate names more generally (done to meet character length limitations) in a single Python script. I have some urgent tasks right now, but I will separate these parts of the flow to the static files this weekend. |
This makes almost no changes to the fonts from #2438, except:
dotlessi.sc
has been added to the smallcap glyphs