Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encodesans: v3.001 added. #2497

Merged
merged 1 commit into from
Jun 17, 2020
Merged

encodesans: v3.001 added. #2497

merged 1 commit into from
Jun 17, 2020

Conversation

thundernixon
Copy link
Collaborator

This makes almost no changes to the fonts from #2438, except:

  • Static filenames have been improved (the main reason to upgrade).
  • The glyph dotlessi.sc has been added to the smallcap glyphs

@thundernixon thundernixon requested a review from m4rc1e June 11, 2020 22:41
@gf-bot
Copy link

gf-bot commented Jun 11, 2020

Fontbakery report

Fontbakery version: 0.7.27

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
--- Rationale ---

There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.

If Font Bakery is not running on an OSX machine, the machine running Font
Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure
call (rpc).

There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator


  • WARN Could not find ftxvalidator.

[4] EncodeSans[wdth,wght].ttf
🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'.
--- Rationale ---

Some designers adopt the "Reserved Font Name" clause of the OFL license. This
means that the original author reserves the rights to the family name and other
people can only distribute modified versions using a different family name.

Google Fonts published updates to the fonts in the collection in order to fix
issues and/or implement further improvements to the fonts. It is important to
keep the family name so that users of the webfonts can benefit from the
updates. Since it would forbid such usage scenario, all families in the GFonts
collection are required to not adopt the RFN clause.

This check ensures "Reserved Font Name" is not mentioned in the name table.


  • 🔥 FAIL Name table entry ("Copyright 2020 The Encode Project Authors (https://github.com/thundernixon/Encode-Sans), with Reserved Font Name 'Encode Sans'.") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]
🔥 FAIL: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---

Variable font family directories kept in the google/fonts git repo must include
a static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.


  • 🔥 FAIL Please create a subdirectory called "static/" and include in it static font files. [code: missing]
WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
WARN: Combined length of family and style must not exceed 27 characters.
--- Rationale ---

According to a GlyphsApp tutorial [1], in order to make sure all versions of
Windows recognize it as a valid font file, we must make sure that the
concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style
(NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20
characters.

After discussing the problem in more detail at `FontBakery issue #2179 [2] we
decided that allowing up to 27 chars would still be on the safe side, though.

[1]
https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances
[2] https://github.com/googlefonts/fontbakery/issues/2179


  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Encode Sans Condensed Thin' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 3 35 10 125 0
0% 1% 2% 20% 6% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: qa.zip

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 17, 2020

Thanks. LGTM.

@m4rc1e m4rc1e merged commit 7897fe9 into master Jun 17, 2020
@m4rc1e m4rc1e deleted the encodesans branch June 17, 2020 09:42
@thlinard
Copy link
Contributor

Hi @thundernixon

I don't want to delay publication, as this version is much better than the previous one, but why Encode Sans "SC" in nameID 1, 3 and 4 (static files)?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 17, 2020

Good spot @thlinard.

    <namerecord nameID="1" platformID="1" platEncID="0" langID="0x0" unicode="True">
      Encode Sans SC Cnd Black
    </namerecord>
    <namerecord nameID="3" platformID="1" platEncID="0" langID="0x0" unicode="True">
      3.001;GOOG;EncodeSansSC-CndBlack
    </namerecord>
    <namerecord nameID="4" platformID="1" platEncID="0" langID="0x0" unicode="True">
      Encode Sans SC Cnd Black
    </namerecord>

@thundernixon would you mind updating the static files?

@thundernixon
Copy link
Collaborator Author

😬 Thanks for spotting that, @thlinard.

I’ve done a bit of digging, and found that the problem is caused by unwisely combining logic to fix SC names with logic to abbreviate names more generally (done to meet character length limitations) in a single Python script.

I have some urgent tasks right now, but I will separate these parts of the flow to the static files this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants