Ensure fsSelection bit 7 is enabled for VFs #3021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check variable fonts have fsSelection bit 7 enabled.
This was referenced Aug 26, 2020
|
what's the status of this one, @m4rc1e ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently pushed Merriweather Sans VF and it didn't have this bit enabled. This caused the following issue, google/fonts#2631
According to the MS Spec it should be enabled for variable fonts anyway:
https://docs.microsoft.com/en-us/typography/opentype/spec/os2#os2-table-and-opentype-font-variations
I've also updated the style condition so it will work on variable fonts and also added the missing unit test for the fsselection check.
@felipesanches once this is merged, I'll also update the vertical metrics regression check. I'll take another look at this pr later. I want to start submitting better PRs so you don't end up wasting your time correcting my lint errors errors etc.