jost: v3.51 added #2627

EwonRael · 2020-08-20T10:53:08Z

Taken from the upstream repo https://github.com/indestructible-type/Jost/ at commit indestructible-type/Jost@85a1ee9

m4rc1e · 2020-08-26T10:41:37Z

Thanks for PR. Can you please do the following:

Run the VF through gftools fix-vf-meta
Bump the version number (gf has 3.6, yet this font has 3.5). I expect > 3.6.

Any reason why the italic angle has changed from -12 to -10?

m4rc1e · 2020-08-26T10:57:32Z

Fontbakery report

Fontbakery version: 0.7.29

[1] Family checks

⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

com.google.fonts/check/ftxvalidator_is_available

--- Rationale ---

There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.

If Font Bakery is not running on an OSX machine, the machine running Font
Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure
call (rpc).

There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator

⚠ WARN Could not find ftxvalidator.

[3] Jost-Italic[wght].ttf

⚠ WARN: Check copyright namerecords match license file.

com.google.fonts/check/name/license

--- Rationale ---

A known licensing description must be provided in the NameID 14 (LICENSE
DESCRIPTION) entries of the name table.

The source of truth for this check (to determine which license is in use) is a
file placed side-by-side to your font project including the licensing terms.

Depending on the chosen license, one of the following string snippets is
expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name
table:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: License URL matches License text on name table?

com.google.fonts/check/name/license_url

--- Rationale ---

A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.

The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).

The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: Check mark characters are in GDEF mark glyph class

com.google.fonts/check/gdef_mark_chars

--- Rationale ---

Mark characters should be in the GDEF mark glyph class.

⚠ WARN The following mark characters could be in the GDEF mark glyph class:
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+030A, U+030B, U+030C, U+0312, U+0326, U+0327 and U+0328 [code: mark-chars]

[3] Jost[wght].ttf

⚠ WARN: Check copyright namerecords match license file.

com.google.fonts/check/name/license

--- Rationale ---

A known licensing description must be provided in the NameID 14 (LICENSE
DESCRIPTION) entries of the name table.

The source of truth for this check (to determine which license is in use) is a
file placed side-by-side to your font project including the licensing terms.

Depending on the chosen license, one of the following string snippets is
expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name
table:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: License URL matches License text on name table?

com.google.fonts/check/name/license_url

--- Rationale ---

A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.

The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).

The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: Check mark characters are in GDEF mark glyph class

com.google.fonts/check/gdef_mark_chars

--- Rationale ---

Mark characters should be in the GDEF mark glyph class.

⚠ WARN The following mark characters could be in the GDEF mark glyph class:
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+030A, U+030B, U+030C, U+0312, U+0326, U+0327 and U+0328 [code: mark-chars]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	7	74	17	242	0
0%	0%	2%	22%	5%	71%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

Diff images: jost_qa.zip

EwonRael · 2020-08-26T11:04:53Z

I have made the necessary changes

italic angle of -10 is more reflective of the actual angle in the font.

m4rc1e · 2020-08-26T15:10:21Z

@EwonRael can you add these changes to your upstream build script please? I see there hasn't been an update in six days.

EwonRael · 2020-08-26T15:21:07Z

are you looking at google fonts branch?

https://github.com/indestructible-type/Jost/tree/google

I will update master in a min but google branch is better place to pull from

EwonRael · 2020-08-26T15:31:59Z

sorry.. should I have put https://github.com/indestructible-type/Jost/tree/google as upstream repo? I'm new at all this

thlinard · 2020-08-26T22:28:00Z

fsSelection bit 7 should be enabled (fonttools/fontbakery#3021).

EwonRael · 2020-08-31T12:52:23Z

does it look good now? I have made the updates to the fsSelection bit

m4rc1e · 2020-09-01T08:44:15Z

@EwonRael Thanks! LGTM

davelab6 · 2020-09-03T13:42:05Z

@EwonRael will you merge the google branch to main?

EwonRael · 2020-09-03T14:19:35Z

both google and main should be up to date on repo?

Jost #2627, Rubik #2664, Sansita Swashed #2658, Piazzolla #2653, Baskervville Epilogue Grandstander #2648, Merriweather #2632, Syne #2644

* jost: v3.51 added * Jost 3.7 * fsSelection bit 7

Jost #2627, Rubik #2664, Sansita Swashed #2658, Piazzolla #2653, Baskervville Epilogue Grandstander #2648, Merriweather #2632, Syne #2644

jost: v3.51 added

09b2116

EwonRael added 2 commits August 26, 2020 12:57

Merge branch 'master' of https://github.com/google/fonts into jost

87f26e9

Jost 3.7

894d8e0

EwonRael added 2 commits August 27, 2020 09:36

Merge branch 'master' of https://github.com/google/fonts into jost

0b0e68b

fsSelection bit 7

41e5ca3

RosaWagner added the Check font files label Aug 28, 2020

m4rc1e merged commit 9592afd into google:master Sep 1, 2020

davelab6 added a commit that referenced this pull request Sep 9, 2020

Update to_sandbox.txt

3b371af

Jost #2627, Rubik #2664, Sansita Swashed #2658, Piazzolla #2653, Baskervville Epilogue Grandstander #2648, Merriweather #2632, Syne #2644

RosaWagner added to_sandbox and removed Check Font Files labels Sep 9, 2020

RosaWagner added to_production --- Live Font is visible on API and removed in_sandbox labels Sep 23, 2020

davelab6 pushed a commit that referenced this pull request Dec 10, 2020

jost: v3.51 added (#2627)

8aeb318

* jost: v3.51 added * Jost 3.7 * fsSelection bit 7

davelab6 added a commit that referenced this pull request Dec 10, 2020

Update to_sandbox.txt

e3b33c2

Jost #2627, Rubik #2664, Sansita Swashed #2658, Piazzolla #2653, Baskervville Epilogue Grandstander #2648, Merriweather #2632, Syne #2644

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jost: v3.51 added #2627

jost: v3.51 added #2627

EwonRael commented Aug 20, 2020

m4rc1e commented Aug 26, 2020

m4rc1e commented Aug 26, 2020

EwonRael commented Aug 26, 2020 •

edited

Loading

m4rc1e commented Aug 26, 2020

EwonRael commented Aug 26, 2020

EwonRael commented Aug 26, 2020

thlinard commented Aug 26, 2020

EwonRael commented Aug 31, 2020

m4rc1e commented Sep 1, 2020

davelab6 commented Sep 3, 2020

EwonRael commented Sep 3, 2020

jost: v3.51 added #2627

jost: v3.51 added #2627

Conversation

EwonRael commented Aug 20, 2020

m4rc1e commented Aug 26, 2020

m4rc1e commented Aug 26, 2020

Fontbakery report

Summary

Diff images: jost_qa.zip

EwonRael commented Aug 26, 2020 • edited Loading

m4rc1e commented Aug 26, 2020

EwonRael commented Aug 26, 2020

EwonRael commented Aug 26, 2020

thlinard commented Aug 26, 2020

EwonRael commented Aug 31, 2020

m4rc1e commented Sep 1, 2020

davelab6 commented Sep 3, 2020

EwonRael commented Sep 3, 2020

EwonRael commented Aug 26, 2020 •

edited

Loading