Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extensionPack instead of extensionDependencies property for defining pack #562

Closed
sandy081 opened this issue Aug 15, 2018 · 2 comments
Closed
Labels
type:feedback Feedback for new features

Comments

@sandy081
Copy link

From release v1.26, defining an Extension Pack now uses a new property called extensionPack instead of extensionDependencies in package.json. This is because extensionDependencies is mainly used to define functional dependencies and an Extension Pack should not have any functional dependencies with its bundled extensions and they should be manageable independent of the pack.

So please use extensionPack property for defining the pack.

For more details refer to Release notes

vazexqi added a commit that referenced this issue Aug 15, 2018
@vazexqi
Copy link
Contributor

vazexqi commented Aug 16, 2018

@sandy081 - Is the new extensionPack key only available to v1.26 and above? Or can this also work with older versions? Basically do we need to update our package.json to say

"engines": {
  "vscode": "^1.26.0"
},

We are asking because our current dependency is on version 1.23 for API functionality and we want to determine if we need to bump everything up to 1.26 to take advantage of this new extensionPack.

@sandy081
Copy link
Author

@vazexqi Good question, yes you have to set your engine > 1.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feedback Feedback for new features
Projects
None yet
Development

No branches or pull requests

3 participants