Use new extensionPack key
#563
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #563 +/- ##
========================================
Coverage 72.09% 72.09%
========================================
Files 155 155
Lines 6157 6157
Branches 953 953
========================================
Hits 4439 4439
Misses 1485 1485
Partials 233 233Continue to review full report at Codecov.
|
| @@ -28,7 +28,7 @@ | |||
| "vscode:publish": "node ../../scripts/publish-vsix.js" | |||
| }, | |||
| "categories": ["Extension Packs"], | |||
| "extensionDependencies": [ | |||
| "extensionPack": [ | |||
There was a problem hiding this comment.
Don't we need to update vscode engine version as well ?
There was a problem hiding this comment.
That's a good question. Let me check. I somehow thought it was retroactively applied since this is an extension pack. This is just a key per my understanding.
There was a problem hiding this comment.
Confirmed on #562 that we do need to bump up to the latest version.
I think this is OK since our stats indicate that our customers are apt to upgrade to the latest version of VS Code quickly.
vazexqi
force-pushed
the
nick/use-new-extensionpack-key
branch
from
3cab42a to
54cdae6
Compare
What does this PR do?
See the changes in https://code.visualstudio.com/updates/v1_26#_extension-packs-revisited
What issues does this PR fix or reference?
#562