Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Lightning LSPs to 2.1.0 / add new activation logic #1253

Merged
merged 12 commits into from
Apr 23, 2019

Conversation

nrkruk
Copy link
Contributor

@nrkruk nrkruk commented Apr 10, 2019

What does this PR do?

  • Update the lightning lsps to 2.1.0
  • Fix settings.json file being overwritten
  • Async startup for aura language server
  • Add vscode settings for configuring LSP activation
  • Cleanup activation logic for internal and external developers

What issues does this PR fix or reference?

#1210

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #1253 into develop will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1253      +/-   ##
===========================================
+ Coverage    72.61%   72.78%   +0.16%     
===========================================
  Files          203      202       -1     
  Lines         7425     7403      -22     
  Branches       776      773       -3     
===========================================
- Hits          5392     5388       -4     
+ Misses        1868     1849      -19     
- Partials       165      166       +1
Impacted Files Coverage Δ
...code-lightning/src/commands/quickpick/quickpick.ts 0% <0%> (ø) ⬆️
...ode-lightning/src/views/component-tree-provider.ts 0% <0%> (ø) ⬆️
...forcedx-vscode-core/src/channels/channelService.ts 83.33% <0%> (-2.39%) ⬇️
...salesforcedx-vscode-lwc/src/dxsupport/waitForDX.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b8578...7d4c686. Read the comment docs.

@nrkruk nrkruk changed the base branch from release/v45.10.0 to develop April 10, 2019 18:25
@nrkruk nrkruk changed the title merge lsp changes into release branch update Lightning LSPs to 2.1.0 / add new activation logic Apr 10, 2019
@nrkruk
Copy link
Contributor Author

nrkruk commented Apr 10, 2019

This is the same PR as (#1231), but with cleanup / comments addressed

@nrkruk nrkruk requested review from lcampos and midzelis April 10, 2019 18:31
@@ -28,7 +28,7 @@
"aura-language-server": "2.1.0",
"change-case": "^3.1.0",
"lightning-lsp-common": "2.1.0",
"open": "^6.0.0",
"open": "6.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnanyaJha this fixes the compile issue we're seeing this morning with using version 6.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants