-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Lightning LSPs to 2.1.0 / add new activation logic #1253
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1253 +/- ##
===========================================
+ Coverage 72.61% 72.78% +0.16%
===========================================
Files 203 202 -1
Lines 7425 7403 -22
Branches 776 773 -3
===========================================
- Hits 5392 5388 -4
+ Misses 1868 1849 -19
- Partials 165 166 +1
Continue to review full report at Codecov.
|
This is the same PR as (#1231), but with cleanup / comments addressed |
5275fce
to
7d4c686
Compare
@@ -28,7 +28,7 @@ | |||
"aura-language-server": "2.1.0", | |||
"change-case": "^3.1.0", | |||
"lightning-lsp-common": "2.1.0", | |||
"open": "^6.0.0", | |||
"open": "6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnanyaJha this fixes the compile issue we're seeing this morning with using version 6.2.0.
What does this PR do?
What issues does this PR fix or reference?
#1210