Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new activation logic for lightning and lwc extensions (#1253) #1279

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Apr 23, 2019

What does this PR do?

Updates the activation events for lightning and lwc extensions. Address the compilation issue with open dependency.

What issues does this PR fix or reference?

@W-6075727@

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #1279 into release/v45.12.0 will increase coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v45.12.0    #1279     +/-   ##
===================================================
+ Coverage             72.61%   72.82%   +0.2%     
===================================================
  Files                   203      202      -1     
  Lines                  7425     7403     -22     
  Branches                776      773      -3     
===================================================
- Hits                   5392     5391      -1     
+ Misses                 1868     1848     -20     
+ Partials                165      164      -1
Impacted Files Coverage Δ
...code-lightning/src/commands/quickpick/quickpick.ts 0% <0%> (ø) ⬆️
...ode-lightning/src/views/component-tree-provider.ts 0% <0%> (ø) ⬆️
...salesforcedx-vscode-lwc/src/dxsupport/waitForDX.ts
...edx-vscode-core/src/telemetry/telemetryReporter.ts 53.52% <0%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b8578...26113b1. Read the comment docs.

@lcampos lcampos merged commit 75cf332 into release/v45.12.0 Apr 23, 2019
@lcampos lcampos deleted the lcampos/port-1231 branch April 23, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants