Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: pin @types/chai to 4.3.0 as 4.3.1 has introduced breaking changes #4032

Closed
wants to merge 2 commits into from
Closed

build: pin @types/chai to 4.3.0 as 4.3.1 has introduced breaking changes #4032

wants to merge 2 commits into from

Conversation

mohanraj-r
Copy link
Contributor

@mohanraj-r mohanraj-r commented Apr 14, 2022 •
edited
Loading

What does this PR do?

  • pin @types/chai to 4.3.0 as 4.3.1 has introduced breaking changes

What issues does this PR fix or reference?

@W-10994021@

Functionality Before

Build is broken in main and multiple branches

Functionality After

Build is fixed

@mohanraj-r mohanraj-r requested a review from a team as a code owner April 14, 2022 00:26
@mohanraj-r mohanraj-r requested a review from klewis-sfdc April 14, 2022 00:26
@mohanraj-r mohanraj-r self-assigned this Apr 14, 2022
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-10994021

@mohanraj-r mohanraj-r requested a review from jeffb-sfdc April 14, 2022 00:28
@jag-j jag-j changed the base branch from develop to main April 14, 2022 00:40
@jag-j jag-j requested a review from a team as a code owner April 14, 2022 00:40
@jag-j jag-j changed the base branch from main to develop April 14, 2022 00:42
@mohanraj-r
Copy link
Contributor Author

Superseded by #4033

@mohanraj-r mohanraj-r closed this Apr 14, 2022
@mohanraj-r mohanraj-r deleted the mohanraj-r/fix_types_chai branch April 14, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffb-sfdc jeffb-sfdc jeffb-sfdc approved these changes

@klewis-sfdc klewis-sfdc Awaiting requested review from klewis-sfdc klewis-sfdc was automatically assigned from forcedotcom/ide-experience

Assignees

@mohanraj-r mohanraj-r

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohanraj-r @uip-robot-zz @jeffb-sfdc